Skip to content

[ES|QL] Bump Monaco highlighting library#220345

Merged
vadimkibana merged 1 commit intoelastic:mainfrom
vadimkibana:fix-func-highlighting
May 7, 2025
Merged

[ES|QL] Bump Monaco highlighting library#220345
vadimkibana merged 1 commit intoelastic:mainfrom
vadimkibana:fix-func-highlighting

Conversation

@vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented May 7, 2025 •
edited by kibanamachine
Loading

Summary

  • Fixes highlighting at the beginning and mid of keywords
image

@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.1.0 v8.19.0 labels May 7, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented May 7, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana vadimkibana added the backport:version Backport to applied version labels label May 7, 2025
stratoula
stratoula approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for beginning and mid as the description says 🙌

@elasticmachine
Copy link
Contributor

elasticmachine commented May 7, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.7MB 3.7MB +14.0B

@vadimkibana vadimkibana merged commit 1d1d650 into elastic:main May 7, 2025
26 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented May 7, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14882653281

@kibanamachine
Copy link
Contributor

kibanamachine commented May 7, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Inference] Instrument inference with OpenTelemetry (#218694)
- Update misc security solution deps (#219746)
- [ska][x-pack] relocate api_integration tests [3] (#219518)
- [upgrade assistant] Create upgrade-assistant package, stub out storybook usage (#218705)

Manual backport

To create the backport manually run:

node scripts/backport --pr 220345

Questions ?

Please refer to the Backport tool documentation

@vadimkibana vadimkibana mentioned this pull request May 7, 2025
Merged
@vadimkibana
Copy link
Contributor Author

vadimkibana commented May 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

vadimkibana added a commit to vadimkibana/kibana that referenced this pull request May 7, 2025
@vadimkibana
[ES|QL] Bump Monaco highlighting library (elastic#220345)
ee5137b 
## Summary

- [x] Fixes highlighting at the beginning and mid of keywords

<img width="704" alt="image"
src="https://github.com/user-attachments/assets/9f9f5b97-9602-4e1a-b3af-9033c9371793"
/>

(cherry picked from commit 1d1d650)

# Conflicts:
#	package.json
#	yarn.lock
This was referenced May 7, 2025
Merged
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 9, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented May 9, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @vadimkibana

vadimkibana added a commit that referenced this pull request May 9, 2025
@vadimkibana
[8.19] [ES|QL] Bump Monaco highlighting library (#220345) (#220378)
5f5801d 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Bump Monaco highlighting library
(#220345)](#220345)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"82822460+vadimkibana@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-07T11:52:01Z","message":"[ES|QL]
Bump Monaco highlighting library (#220345)\n\n## Summary\n\n- [x] Fixes
highlighting at the beginning and mid of keywords\n\n<img width=\"704\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9f9f5b97-9602-4e1a-b3af-9033c9371793\"\n/>","sha":"1d1d650769e941b4deca79018db29907787e3e91","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Bump Monaco highlighting
library","number":220345,"url":"https://github.com/elastic/kibana/pull/220345","mergeCommit":{"message":"[ES|QL]
Bump Monaco highlighting library (#220345)\n\n## Summary\n\n- [x] Fixes
highlighting at the beginning and mid of keywords\n\n<img width=\"704\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9f9f5b97-9602-4e1a-b3af-9033c9371793\"\n/>","sha":"1d1d650769e941b4deca79018db29907787e3e91"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220345","number":220345,"mergeCommit":{"message":"[ES|QL]
Bump Monaco highlighting library (#220345)\n\n## Summary\n\n- [x] Fixes
highlighting at the beginning and mid of keywords\n\n<img width=\"704\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9f9f5b97-9602-4e1a-b3af-9033c9371793\"\n/>","sha":"1d1d650769e941b4deca79018db29907787e3e91"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 9, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@vadimkibana @akowalska622
[ES|QL] Bump Monaco highlighting library (elastic#220345)
c71a478 
## Summary

- [x] Fixes highlighting at the beginning and mid of keywords

<img width="704" alt="image"
src="https://github.com/user-attachments/assets/9f9f5b97-9602-4e1a-b3af-9033c9371793"
/>
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@vadimkibana @qn895
[ES|QL] Bump Monaco highlighting library (elastic#220345)
41d31c1 
## Summary

- [x] Fixes highlighting at the beginning and mid of keywords

<img width="704" alt="image"
src="https://github.com/user-attachments/assets/9f9f5b97-9602-4e1a-b3af-9033c9371793"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

@drewdaemon drewdaemon Awaiting requested review from drewdaemon

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vadimkibana @elasticmachine @kibanamachine @stratoula