[Security Solution][Endpoint] Update background tasks for automated response actions and completing 3rd party EDR actions to support spaces#219978
Merged
paul-tavares merged 16 commits intoelastic:mainfrom May 8, 2025
Conversation
…eId` (new option) when using the unsecured client
…ces per agent type and process it.
…endingActions()`
paul-tavares
added
release_note:skip
2 tasks
…g actions and spaces is enabled
paul-tavares
changed the title
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
approved these changes
May 7, 2025
Contributor
szwarckonrad
left a comment
szwarckonrad
left a comment
There was a problem hiding this comment.
Code LGTM - I didn't spot anything concerning. The changes make sense, but I'll defer to Ash's opinion since he has more exposure to response actions than I do.
…omplete-task-to-support-spaces
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
ashokaditya
approved these changes
May 8, 2025
Member
ashokaditya
left a comment
ashokaditya
left a comment
There was a problem hiding this comment.
Thanks for the updates and detailed comments everywhere!
| }); | ||
|
|
||
| it('should error is action id is not accessible in active space', async () => { | ||
| it('should error if action id is not accessible in active space', async () => { |
Member
There was a problem hiding this comment.
Thanks for updating this. I think there are a couple more instances of should error is... in similar tests that you can also update.
paul-tavares
deleted the
task/olm-12313-update-3rd-party-edr-action-complete-task-to-support-spaces
branch
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…esponse actions and completing 3rd party EDR actions to support spaces (elastic#219978) ## Summary The following changes were done in support of Endpoint space awareness: - The background task that checks and completes pending 3rd party response actions was updated to ensure that action are completed using a response actions client scoped to the space that the response action was created from. - The automated response actions process was updated to use the alert's space ID when retrieving a response action client
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…esponse actions and completing 3rd party EDR actions to support spaces (elastic#219978) ## Summary The following changes were done in support of Endpoint space awareness: - The background task that checks and completes pending 3rd party response actions was updated to ensure that action are completed using a response actions client scoped to the space that the response action was created from. - The automated response actions process was updated to use the alert's space ID when retrieving a response action client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following changes were done in support of Endpoint space awareness:
Important
When the space awareness feature flag is enabled, the completion of 3rd party response action created from a space other than
defaultwill fail and response actions for those agents will remain in Pending state until this bug in the Stack Connectors is addressed: #219975Testing space awareness setup
Enable feature flags
Switch Fleet to Space aware
Ensure that a
9.1.0xendpoint package is installedSpace awareness needs to have the latest 9.1 package installed in fleet. Ensure that is the case prior to creating policies by going to the integrations page, enabling
Display beta integrationsand then clicking on Elastic Defend and installing the latest 9.1 pre-release package version.Add data
You should now be all setup to load data for testing. Remember that space data visibility is mostly driven by Fleet and how Policies are setup and shared between spaces - Agent Policies now have a Space ID field to manage this.
Our scripts that run live VMs for each type o9f EDR have been updated to support a
--spaceIdCLI argument and thus can be used to target specific spaces.Checklist