[Security Solution] [Onboarding] a11y: Fix incorrect navigation after Save on AI assistant modal dialog#219935

Merged

agusruidiazgd merged 7 commits intoelastic:mainfrom

agusruidiazgd:fix/a11y-security-issue-204211

May 21, 2025

Contributor

agusruidiazgd commented May 2, 2025 •

edited by kibanamachine

Loading

Summary

Closes: #204211

Screen.Recording.2025-05-02.at.15.19.16.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Unit or functional tests were updated or added to match the most common scenarios


          [Security Solution] fix incorrect navigation when getting errors afte…

573128a

…r Save on AI assistant modal dialog

agusruidiazgd added Project:Accessibility release_note:skip v9.0.0 Team:Threat Hunting:Explore ci:cloud-deploy v9.1.0 v8.19.0 labels

agusruidiazgd self-assigned this

agusruidiazgd requested a review from a team as a code owner

May 2, 2025 13:21

Contributor

elasticmachine commented May 2, 2025

Pinging @elastic/kibana-accessibility (Project:Accessibility)

Contributor

elasticmachine commented May 2, 2025

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

Contributor Author

agusruidiazgd commented May 2, 2025

@elasticmachine merge upstream


          Merge branch 'main' into fix/a11y-security-issue-204211

fb8a51f

agusruidiazgd commented

View reviewed changes

...riggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx

                     className="actConnectorModal"
                     css={css`
                       z-index: 9000;
+                      width: ${actionTypeRegistry.get(actionType.id).modalWidth};

Contributor Author

agusruidiazgd May 2, 2025

ESLint auto-fix

Contributor Author

agusruidiazgd commented May 5, 2025

@elasticmachine merge upstream


          Merge branch 'main' into fix/a11y-security-issue-204211

fe9da05

Contributor Author

agusruidiazgd commented May 8, 2025

@elasticmachine merge upstream


          Merge branch 'main' into fix/a11y-security-issue-204211

7c4bd6b

Contributor Author

agusruidiazgd commented May 19, 2025

@elasticmachine merge upstream


          Merge branch 'main' into fix/a11y-security-issue-204211

2df47d6

adcoelho reviewed

View reviewed changes

...riggers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx Outdated Show resolved Hide resolved

adcoelho reviewed

View reviewed changes

...m/plugins/shared/triggers_actions_ui/public/application/components/simple_connector_form.tsx Outdated

                       <React.Fragment key={`config.${id}`}>
-                        <FormRow id={`config.${id}`} {...restConfigSchema} readOnly={readOnly} />
+                        <FormRow
+                          euiFieldProps={{ 'aria-invalid': isEdit }}

Contributor

adcoelho May 20, 2025

Why isEdit, shouldn't this depend on whether the form is valid?

Contributor Author

agusruidiazgd May 20, 2025

I realized that it wasn’t necessary to manually add an aria-invalid attribute, because when you pass the isInvalid prop, EUI automatically adds aria-invalid="true" to the input so I've removed this lines of code.

also @adcoelho I noticed that the isEdit boolean is not used in this component, should we remove it ?

agusruidiazgd added 2 commits

May 20, 2025 14:16


          fix comments

adad113


          fix incorrect use of aria-invalid

ac23e57

agusruidiazgd requested a review from adcoelho

May 20, 2025 12:37

Contributor

elasticmachine commented May 20, 2025 •

edited

Loading

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #15

Test Failures

[job] [logs] FTR Configs #15 / Cloud Security Posture Findings Page - Grouping "after all" hook in "Findings Page - Grouping"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.4MB	+192.0B

History

💛 Build #300689 was flaky 2df47d6
💚 Build #299625 succeeded 7c4bd6b
💚 Build #298474 succeeded fe9da05
💔 Build #298221 failed fb8a51f

cc @agusruidiazgd

adcoelho approved these changes

View reviewed changes

agusruidiazgd merged commit 63f75bd into elastic:main

7 checks passed

Contributor

kibanamachine commented Aug 7, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

26 similar comments

Contributor

kibanamachine commented Aug 8, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 11, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 12, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 13, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 14, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 15, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 18, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 19, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 20, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 21, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 22, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 25, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 26, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 27, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 28, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Aug 29, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 1, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 2, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 4, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 5, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 8, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 9, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 10, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 11, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 12, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

Contributor

kibanamachine commented Sep 15, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @agusruidiazgd

agusruidiazgd added a commit that referenced this pull request


          [8.19] [Security Solution] [Onboarding] a11y: Fix incorrect navigatio…

67b48e0

…n after Save on AI assistant modal dialog (#219935) (#221119)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution] [Onboarding] a11y: Fix incorrect navigation after
Save on AI assistant modal dialog
(#219935)](#219935)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Agustina Nahir
Ruidiaz","email":"61565784+agusruidiazgd@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-21T09:51:43Z","message":"[Security
Solution] [Onboarding] a11y: Fix incorrect navigation after Save on AI
assistant modal dialog (#219935)\n\n## Summary\n\nCloses:
https://github.com/elastic/kibana/issues/204211\n\n\nhttps://github.com/user-attachments/assets/ce60a37a-913d-4c17-bf3c-0192b1e99ddc\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"63f75bd15126deb2f5cf02434302565a7a2cdd73","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Threat
Hunting:Explore","backport:prev-minor","ci:cloud-deploy","v9.1.0","v8.19.0"],"title":"[Security
Solution] [Onboarding] a11y: Fix incorrect navigation after Save on AI
assistant modal
dialog","number":219935,"url":"https://github.com/elastic/kibana/pull/219935","mergeCommit":{"message":"[Security
Solution] [Onboarding] a11y: Fix incorrect navigation after Save on AI
assistant modal dialog (#219935)\n\n## Summary\n\nCloses:
https://github.com/elastic/kibana/issues/204211\n\n\nhttps://github.com/user-attachments/assets/ce60a37a-913d-4c17-bf3c-0192b1e99ddc\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"63f75bd15126deb2f5cf02434302565a7a2cdd73"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219935","number":219935,"mergeCommit":{"message":"[Security
Solution] [Onboarding] a11y: Fix incorrect navigation after Save on AI
assistant modal dialog (#219935)\n\n## Summary\n\nCloses:
https://github.com/elastic/kibana/issues/204211\n\n\nhttps://github.com/user-attachments/assets/ce60a37a-913d-4c17-bf3c-0192b1e99ddc\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"63f75bd15126deb2f5cf02434302565a7a2cdd73"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine added v8.19.4 and removed backport missing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cloud-deploy Project:Accessibility release_note:skip v8.19.0 v8.19.4 v9.0.3 v9.1.0