Skip to content

Comments

[9.0] Fix ignored dynamic templates (#219875)#219900

Merged
kibanamachine merged 2 commits intoelastic:9.0from
kibanamachine:backport/9.0/pr-219875
May 2, 2025
Merged

[9.0] Fix ignored dynamic templates (#219875)#219900
kibanamachine merged 2 commits intoelastic:9.0from
kibanamachine:backport/9.0/pr-219875

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

This PR fixes the bug introduced with:
elastic#216719

We didn't pass the dynamic_templates param while creating the component
template.
The fields were still being added because the fields were marked as
`dynamic: true`

As the dynamic_template was ignored, the fields were added with an extra
mapping like `filedname.keyword`
This PR fixes that too.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8c6c928)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 2, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) May 2, 2025 08:35
@prodsecmachine
Copy link
Collaborator

prodsecmachine commented May 2, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@elasticmachine
Copy link
Contributor

elasticmachine commented May 2, 2025

💔 Build Failed

Failed CI Steps

History

cc @ersin-erdal

@kibanamachine kibanamachine merged commit b3582bc into elastic:9.0 May 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants