Skip to content

Comments

[ES|QL] Renames the ESQLRealField type to ESQLFieldWithMetadata#219894

Merged
stratoula merged 2 commits intoelastic:mainfrom
stratoula:rename-esql-real-fields
May 2, 2025
Merged

[ES|QL] Renames the ESQLRealField type to ESQLFieldWithMetadata#219894
stratoula merged 2 commits intoelastic:mainfrom
stratoula:rename-esql-real-fields

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented May 2, 2025

Summary

Improves the naming of the ESQLRealField type

@prodsecmachine
Copy link
Collaborator

prodsecmachine commented May 2, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels May 2, 2025
@stratoula stratoula marked this pull request as ready for review May 2, 2025 13:36
@stratoula stratoula requested a review from a team as a code owner May 2, 2025 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stratoula stratoula merged commit c89c1ee into elastic:main May 2, 2025
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14797264736

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 219894

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request May 6, 2025
…tic#219894)

## Summary

Improves the naming of the `ESQLRealField` type

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c89c1ee)

# Conflicts:
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/hover.ts
@stratoula
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit that referenced this pull request May 6, 2025
#219894) (#220190)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Renames the ESQLRealField type to ESQLFieldWithMetadata
(#219894)](#219894)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-05-02T14:32:45Z","message":"[ES|QL]
Renames the ESQLRealField type to ESQLFieldWithMetadata (#219894)\n\n##
Summary\n\nImproves the naming of the `ESQLRealField`
type\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c89c1ee30dd875b1edfbc479f7120b7e1915bc4c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Renames the ESQLRealField type to
ESQLFieldWithMetadata","number":219894,"url":"https://github.com/elastic/kibana/pull/219894","mergeCommit":{"message":"[ES|QL]
Renames the ESQLRealField type to ESQLFieldWithMetadata (#219894)\n\n##
Summary\n\nImproves the naming of the `ESQLRealField`
type\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c89c1ee30dd875b1edfbc479f7120b7e1915bc4c"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219894","number":219894,"mergeCommit":{"message":"[ES|QL]
Renames the ESQLRealField type to ESQLFieldWithMetadata (#219894)\n\n##
Summary\n\nImproves the naming of the `ESQLRealField`
type\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"c89c1ee30dd875b1edfbc479f7120b7e1915bc4c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…tic#219894)

## Summary

Improves the naming of the `ESQLRealField` type

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
…tic#219894)

## Summary

Improves the naming of the `ESQLRealField` type

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants