Skip to content

[8.18] [Security Solution] [Detections] Removes tech preview text from eql seq suppression ui (#219870) #219891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhurley14 merged 3 commits into from
May 2, 2025
Merged

[8.18] [Security Solution] [Detections] Removes tech preview text from eql seq suppression ui (#219870) #219891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f42aac7
[Security Solution] [Detections] Removes tech preview text from eql s…
dhurley14 May 2, 2025
fd845bd
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine May 2, 2025
ae42526
fixes failing test
dhurley14 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/solutions/security/plugins/security_solution/common/detection_engine/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const SUPPRESSIBLE_ALERT_RULES_GA: Type[] = [
'new_terms',
'threat_match',
'machine_learning',
'eql',
];

export const RISK_SCORE_LOW = 21;
Expand Down
5 changes: 1 addition & 4 deletions x-pack/solutions/security/plugins/security_solution/common/detection_engine/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,7 @@ describe('Alert Suppression Rules', () => {
expect(isSuppressionRuleInGA('threat_match')).toBe(true);
expect(isSuppressionRuleInGA('new_terms')).toBe(true);
expect(isSuppressionRuleInGA('machine_learning')).toBe(true);
});

test('should return false for rule type suppression in tech preview', () => {
expect(isSuppressionRuleInGA('eql')).toBe(false);
expect(isSuppressionRuleInGA('eql')).toBe(true);
});
});
describe('isSuppressionRuleConfiguredWithDuration', () => {
Expand Down
4 changes: 0 additions & 4 deletions .../cypress/e2e/detection_response/detection_engine/rule_creation/eql_rule_suppression.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
SUPPRESS_FOR_DETAILS,
SUPPRESS_BY_DETAILS,
SUPPRESS_MISSING_FIELD,
DETAILS_TITLE,
} from '../../../../screens/rule_details';

const SUPPRESS_BY_FIELDS = ['agent.type'];
Expand Down Expand Up @@ -71,9 +70,6 @@ describe(
'have.text',
'Suppress and group alerts for events with missing fields'
);

// suppression functionality should be under Tech Preview
cy.contains(DETAILS_TITLE, SUPPRESS_FOR_DETAILS).contains('Technical Preview');
});

fillAboutRuleMinimumAndContinue(rule);
Expand Down
4 changes: 0 additions & 4 deletions ...2e/detection_response/detection_engine/rule_creation/eql_rule_suppression_ess_basic.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
SUPPRESS_FOR_DETAILS,
SUPPRESS_BY_DETAILS,
SUPPRESS_MISSING_FIELD,
DETAILS_TITLE,
ALERT_SUPPRESSION_INSUFFICIENT_LICENSING_ICON,
} from '../../../../screens/rule_details';
import { startBasicLicense } from '../../../../tasks/api_calls/licensing';
Expand Down Expand Up @@ -77,9 +76,6 @@ describe(
'have.text',
'Do not suppress alerts for events with missing fields'
);

// suppression functionality should be under Tech Preview
cy.contains(DETAILS_TITLE, SUPPRESS_FOR_DETAILS).contains('Technical Preview');
});

// Platinum license is required for configuration to apply
Expand Down
4 changes: 0 additions & 4 deletions ...e2e/detection_response/detection_engine/rule_creation/eql_rule_suppression_sequence.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
SUPPRESS_FOR_DETAILS,
SUPPRESS_BY_DETAILS,
SUPPRESS_MISSING_FIELD,
DETAILS_TITLE,
} from '../../../../screens/rule_details';

const SUPPRESS_BY_FIELDS = ['agent.type'];
Expand Down Expand Up @@ -70,9 +69,6 @@ describe(
'have.text',
'Suppress and group alerts for events with missing fields'
);

// suppression functionality should be under Tech Preview
cy.contains(DETAILS_TITLE, SUPPRESS_FOR_DETAILS).contains('Technical Preview');
});

fillAboutRuleMinimumAndContinue(rule);
Expand Down