[Rules] Adding actions to the rules details action menu (Part 2)#219790
Merged
baileycash-elastic merged 15 commits intoelastic:mainfrom May 8, 2025
Merged
[Rules] Adding actions to the rules details action menu (Part 2)#219790baileycash-elastic merged 15 commits intoelastic:mainfrom
baileycash-elastic merged 15 commits intoelastic:mainfrom
Conversation
baileycash-elastic
added a commit
that referenced
this pull request
May 1, 2025
…9635) ## Summary Partially implements #199421 This PR adds snooze and enable/disable options to the action menu of the rule details header action menu. Note: A second PR with the other 2 required actions and a slight redesign is [here](#219790)  
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 1, 2025
…stic#219635) ## Summary Partially implements elastic#199421 This PR adds snooze and enable/disable options to the action menu of the rule details header action menu. Note: A second PR with the other 2 required actions and a slight redesign is [here](elastic#219790)   (cherry picked from commit 1ee2f62)
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
baileycash-elastic
changed the title
baileycash-elastic
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
baileycash-elastic
added
backport:version
kdelemme
reviewed
May 1, 2025
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
Some comments about react hook query usage that i think we should fix
x-pack/solutions/observability/plugins/observability/public/hooks/use_update_api_key.ts
Outdated
Show resolved
Hide resolved
.../observability/plugins/observability/public/pages/rule_details/components/header_actions.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Contributor
|
One question, why the bell icons are in different state by default?
|
.../observability/plugins/observability/public/pages/rule_details/components/header_actions.tsx
Outdated
Show resolved
Hide resolved
…ges/rule_details/components/header_actions.tsx Reversing the condition to make the icon consistent with the interactive area of the status panel - and because the snooze state can be updated without updating the actual mute state
kdelemme
approved these changes
May 7, 2025
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
LGTM and tested locally.
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/14897800049 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2025
…stic#219790) (cherry picked from commit 0129955)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
May 14, 2025
…2) (#219790) (#220458) # Backport This will backport the following commits from `main` to `8.19`: - [[Rules] Adding actions to the rules details action menu (Part 2) (#219790)](#219790) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"bailey.cash@elastic.co"},"sourceCommit":{"committedDate":"2025-05-08T03:14:12Z","message":"[Rules] Adding actions to the rules details action menu (Part 2) (#219790)","sha":"0129955c5d67087c1a74ca2bbf133e25866a36a7","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Rules] Adding actions to the rules details action menu (Part 2)","number":219790,"url":"https://github.com/elastic/kibana/pull/219790","mergeCommit":{"message":"[Rules] Adding actions to the rules details action menu (Part 2) (#219790)","sha":"0129955c5d67087c1a74ca2bbf133e25866a36a7"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219790","number":219790,"mergeCommit":{"message":"[Rules] Adding actions to the rules details action menu (Part 2) (#219790)","sha":"0129955c5d67087c1a74ca2bbf133e25866a36a7"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bailey Cash <bailey.cash@elastic.co>
kibanamachine
removed
the
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…stic#219635) ## Summary Partially implements elastic#199421 This PR adds snooze and enable/disable options to the action menu of the rule details header action menu. Note: A second PR with the other 2 required actions and a slight redesign is [here](elastic#219790)  
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing implementation of #199421
Summary
This PR: