Skip to content

[8.19] [Sharing URLs] Add the ability to switch between relative and absolute time range (#218056)#219755

Merged
kowalczyk-krzysztof merged 1 commit intoelastic:8.19from
kowalczyk-krzysztof:backport/8.19/pr-218056
Apr 30, 2025
Merged

[8.19] [Sharing URLs] Add the ability to switch between relative and absolute time range (#218056)#219755
kowalczyk-krzysztof merged 1 commit intoelastic:8.19from
kowalczyk-krzysztof:backport/8.19/pr-218056

Conversation

@kowalczyk-krzysztof
Copy link
Copy Markdown
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Apr 30, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@kowalczyk-krzysztof
[Sharing URLs] Add the ability to switch between relative and absolut…
2f3b77c 
…e time range (elastic#218056)

## Summary

This PR adds the ability to switch between relative and absolute time
range for short links in Share Modal. By default "absolute time" is
pre-selected.

![Screenshot 2025-04-23 at 23 01
07](https://github.com/user-attachments/assets/9b88ec53-fe05-4868-83e4-d93faf4a88de)
![Screenshot 2025-04-23 at 23 01
40](https://github.com/user-attachments/assets/abd5bbed-cee1-450b-bafe-83449dab7f0f)
![Screenshot 2025-04-23 at 23 02
37](https://github.com/user-attachments/assets/22943393-51e9-4faa-a842-95485ea40a99)

Closes: elastic#189156

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 6ab7593)

# Conflicts:
#	src/platform/plugins/shared/share/public/components/tabs/link/link_content.tsx
@kowalczyk-krzysztof kowalczyk-krzysztof added the backport This PR is a backport of another PR label Apr 30, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof enabled auto-merge (squash) April 30, 2025 15:11
@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this pull request Apr 30, 2025
Merged
tsullivan
tsullivan approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 312a9a8 into elastic:8.19 Apr 30, 2025
11 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 30, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / Description renders description correctly
  • [job] [logs] Jest Tests #15 / Severity level panel renders correctly

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 85 87 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 612.9KB 613.0KB +74.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 58.7KB 62.5KB +3.8KB

@kowalczyk-krzysztof kowalczyk-krzysztof deleted the backport/8.19/pr-218056 branch August 1, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kowalczyk-krzysztof @elasticmachine @tsullivan