Skip to content

[8.19] [Investigations][Timeline] - Run Object.keys less frequently (#219629)#219749

Merged
kibanamachine merged 2 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-219629
May 7, 2025
Merged

[8.19] [Investigations][Timeline] - Run Object.keys less frequently (#219629)#219749
kibanamachine merged 2 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-219629

Conversation

@kibanamachine
Copy link
Contributor

@kibanamachine kibanamachine commented Apr 30, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@michaelolo24 @kibanamachine
[Investigations][Timeline] - Run Object.keys less frequently (elastic…
38c3ac1 
…#219629)

## Summary

This PR makes a minor performance improvement by pulling out the
`Object.keys` call on `hit.fields` out of any unnecessary loops.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit fd4ff0a)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Apr 30, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) April 30, 2025 14:57
@kibanamachine kibanamachine mentioned this pull request Apr 30, 2025
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 30, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #51 / X-Pack Accessibility Tests - Group 3 Upgrade Assistant Accessibility ES deprecations logs flyout with logs collection disabled

Metrics [docs]

✅ unchanged

History

cc @michaelolo24

@kibanamachine kibanamachine merged commit c33803c into elastic:8.19 May 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@michaelolo24 michaelolo24

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @elasticmachine @michaelolo24