-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Security][9.1] Security roles siemV3 migration for Global Artifact Management
#219566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
df14a42
d3c523a
c35e932
119b0b9
1135b7d
1d787b2
4a19f63
b1f4b15
d09be38
a4758dd
b94861f
fbd44e8
426c418
47693fd
6b7ae16
b053fd6
6f1fcad
f8635b7
573322b
3fe4dca
22a2cb7
39593b4
f61fe51
ad2b84c
a55a213
8d0f9d1
a0b5813
c8ff196
6b6c75a
8c994ff
0cb4625
3ac7be8
fbbcf8b
efe83e8
b85da1e
0f5b9a3
970674a
e40d923
4d5dec8
1b37885
88d0605
4b4f49e
ea21521
b8d90d0
e06d67b
a26a1ca
44d141d
a4dd40a
860d72c
90e4245
d57b5f2
2ec6329
bff5fc3
de05a3b
1c31f56
309abb3
93d8721
a7f0bd8
1dadbf6
b88c777
5132bc3
da18aac
cee449a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,17 +23,33 @@ xpack.features.overrides: | |
| securitySolutionNotes.hidden: true | ||
| siem.description: null | ||
| siemV2.description: null | ||
| siemV3.description: null | ||
| securitySolutionSiemMigrations.hidden: true | ||
|
|
||
| ## Fine-tune the security solution essentials feature privileges. These feature privilege overrides are set individually for each project type. Also, refer to `serverless.yml` for the project-agnostic overrides. | ||
| siemV3: | ||
| privileges: | ||
| all.composedOf: | ||
| ## Limited values so the fields from serverless.yml or serverless.security.yml are overwritten | ||
| ## We do not need to compose siemV3 from maps and visualizations because these functionalities are disabled in this tier | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Looking at this config, I don't see maps or visualizations being disabled. Is this statement still accurate (
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tomsonpl, @ashokaditya, could you jump in please?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @azasypkin your assumption is correct, we reverted the disable maps, visualizations etc in config's change.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, additional part: the RBAC is also hidden, so the current logic seems fine @gergoabraham
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Roger that, just to make sure I understand - we switched to
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the end the team notices that we need to use some |
||
| - feature: "discover_v2" | ||
| privileges: [ "all" ] | ||
| ## We need limited access to fleet (v1) in order to use integrations | ||
| - feature: "fleet" | ||
| privileges: [ "all" ] | ||
| read.composedOf: | ||
| - feature: "discover_v2" | ||
| privileges: [ "read" ] | ||
| - feature: "fleet" | ||
| privileges: [ "read" ] | ||
| siemV2: | ||
| privileges: | ||
| all.composedOf: | ||
| ## Limited values so the fields from serverless.yml or serverless.security.yml are overwritten | ||
| ## We do not need to compose siemV2 from maps and visualizations because these functionalities are disabled in this tier | ||
| - feature: "discover_v2" | ||
| privileges: [ "all" ] | ||
| ## We need limited read access to fleet (v1) in order to use integrations | ||
| ## We need limited access to fleet (v1) in order to use integrations | ||
| - feature: "fleet" | ||
| privileges: [ "all" ] | ||
| read.composedOf: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I believe
descriptionis only used in the role management UI to describe a feature. The UI shows only the latest feature version, so you could clean up this config a bit by removing entries for deprecated features and leaving only v3.