[7.17] change reporting usage of handlebars to @kbn/handlebars (#217778)#219545
Closed
pmuellr wants to merge 1 commit intoelastic:7.17from
Closed
[7.17] change reporting usage of handlebars to @kbn/handlebars (#217778)#219545pmuellr wants to merge 1 commit intoelastic:7.17from
handlebars to @kbn/handlebars (#217778)#219545pmuellr wants to merge 1 commit intoelastic:7.17from
Conversation
…217778) Change reporting's usage of `handlebars` to `@kbn/handlebars`. Also added a test to ensure user input is HTML escaped (it always has been, this just tests it). There should be no change to the final rendered output, at all. These changes only affect PDF and PNG reports, not CSV reports. (cherry picked from commit 3b5e96a) # Conflicts: # x-pack/platform/plugins/shared/screenshotting/server/browsers/chromium/templates/index.ts # x-pack/platform/plugins/shared/screenshotting/tsconfig.json
1 task
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History |
Contributor
Author
|
Closing this backport. Handlebars was introduced in PR #130546 for 8.3, and not backported to 7.x, so no fix is needed. |
auto-merge was automatically disabled
April 29, 2025 18:14
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:handlebarsto@kbn/handlebars(#217778)Questions ?
Please refer to the Backport tool documentation