Skip to content

Comments

[AI4DSOC] fix styling to address cutoff when screen is narrow#219306

Merged
kgeller merged 4 commits intoelastic:mainfrom
kgeller:ai4soc-fix-card-cutoff
May 1, 2025
Merged

[AI4DSOC] fix styling to address cutoff when screen is narrow#219306
kgeller merged 4 commits intoelastic:mainfrom
kgeller:ai4soc-fix-card-cutoff

Conversation

@kgeller
Copy link
Contributor

@kgeller kgeller commented Apr 25, 2025

Summary

Fixing the css settings for the AI4DSOC integrations cards so the cards resize when the screen is narrow, instead of getting cut off.

Screenshots

Before

Screenshot 2025-04-25 at 2 42 33 PM

After

Screenshot 2025-04-25 at 2 39 25 PM

Outside of AI4DSOC not impacted

Screenshot 2025-04-25 at 2 33 25 PM

AI4DSOC when not narrow screen

Screenshot 2025-04-25 at 2 50 44 PM

Relates

@kgeller kgeller added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Apr 25, 2025
@kgeller kgeller self-assigned this Apr 25, 2025
@kgeller kgeller changed the title [AI4DSIC] fix styling to address cutoff when screen is narrow [AI4DSOC] fix styling to address cutoff when screen is narrow Apr 25, 2025
@kgeller kgeller marked this pull request as ready for review April 25, 2025 19:09
@kgeller kgeller requested review from a team as code owners April 25, 2025 19:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Security Solution

@kgeller
Copy link
Contributor Author

kgeller commented Apr 25, 2025

run docs-build

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 25, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1412 1413 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +20.0B
Unknown metric groups

API count

id before after diff
fleet 1541 1542 +1

History

cc @kgeller

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@prodsecmachine
Copy link
Collaborator

prodsecmachine commented May 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@kgeller kgeller merged commit 6516cff into elastic:main May 1, 2025
9 checks passed
@kgeller kgeller deleted the ai4soc-fix-card-cutoff branch May 1, 2025 20:43
kapral18 added a commit to kapral18/kibana that referenced this pull request May 4, 2025
…ends-crash

* main: (111 commits)
  [ResponseOps][Rules] Cases action title length too long (elastic#219226)
  [main] Sync bundled packages with Package Storage (elastic#219839)
  Fix ignored dynamic templates (elastic#219875)
  Enforce dependency review by kibana-security workflow (elastic#219262)
  [Security Solution] [Detections] Removes tech preview text from eql seq suppression ui (elastic#219870)
  [Security Solution] Fix alerts table potentially not applying alert assignees (elastic#219460)
  fix(slo): alert deletion (elastic#219876)
  [AI4DSOC] fix styling to address cutoff when screen is narrow (elastic#219306)
  [Security Solution][Endpoint] Response action create and history log API updates in of space awareness (elastic#218674)
  Update publish_oas_docs.sh to deploy Kibana Serverless API docs (elastic#219867)
  feat(slo): lock resource installation (elastic#219747)
  [AI4DSOC] Alert flyout code cleanup (elastic#219810)
  [fleet] fixing `isAgentlessDefault` config usage and readability improvements to `isAgentlessSetupDefault` (elastic#219423)
  feat(slo): Bulk delete UI (elastic#219634)
  m1 demo prep (elastic#219588)
  [Security Solution] Replace sourcerer in EQL tab with dataview picker (elastic#218897)
  [AI4DSOC] Attack discovery widget follow up follow up (elastic#219849)
  [AI Assistant] Fix some OpenAI models not accepting temperature for Inference service (elastic#218887)
  Update dependency msw to ~2.7.5 (main) (elastic#219289)
  Use new client URLs in doc link service (elastic#219600)
  ...
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…c#219306)

## Summary

Fixing the css settings for the AI4DSOC integrations cards so the cards
resize when the screen is narrow, instead of getting cut off.

## Screenshots

### Before
<img width="750" alt="Screenshot 2025-04-25 at 2 42 33 PM"
src="https://github.com/user-attachments/assets/2cb1033f-8998-4fd7-90ee-e7b6ce12c8ef"
/>

### After
<img width="750" alt="Screenshot 2025-04-25 at 2 39 25 PM"
src="https://github.com/user-attachments/assets/dbee50c9-2c90-455c-8dc7-f7cf102d299b"
/>

### Outside of AI4DSOC not impacted
<img width="750" alt="Screenshot 2025-04-25 at 2 33 25 PM"
src="https://github.com/user-attachments/assets/3b3961d5-4276-4da1-b046-3c8b0ac99bbe"
/>

### AI4DSOC when not narrow screen
<img width="750" alt="Screenshot 2025-04-25 at 2 50 44 PM"
src="https://github.com/user-attachments/assets/ff41c130-1691-4fae-baba-8b24e3641337"
/>

Relates 
- elastic/security-team#11789
- elastic#217905
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
…c#219306)

## Summary

Fixing the css settings for the AI4DSOC integrations cards so the cards
resize when the screen is narrow, instead of getting cut off.

## Screenshots

### Before
<img width="750" alt="Screenshot 2025-04-25 at 2 42 33 PM"
src="https://github.com/user-attachments/assets/2cb1033f-8998-4fd7-90ee-e7b6ce12c8ef"
/>

### After
<img width="750" alt="Screenshot 2025-04-25 at 2 39 25 PM"
src="https://github.com/user-attachments/assets/dbee50c9-2c90-455c-8dc7-f7cf102d299b"
/>

### Outside of AI4DSOC not impacted
<img width="750" alt="Screenshot 2025-04-25 at 2 33 25 PM"
src="https://github.com/user-attachments/assets/3b3961d5-4276-4da1-b046-3c8b0ac99bbe"
/>

### AI4DSOC when not narrow screen
<img width="750" alt="Screenshot 2025-04-25 at 2 50 44 PM"
src="https://github.com/user-attachments/assets/ff41c130-1691-4fae-baba-8b24e3641337"
/>

Relates 
- elastic/security-team#11789
- elastic#217905
@kgeller kgeller added backport:version Backport to applied version labels v8.19.0 and removed backport:skip This PR does not require backporting labels Jun 4, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15446633972

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15446633966

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 219306

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 219306

Questions ?

Please refer to the Backport tool documentation

@kgeller
Copy link
Contributor Author

kgeller commented Jun 4, 2025

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kgeller added a commit to kgeller/kibana that referenced this pull request Jun 4, 2025
…c#219306)

## Summary

Fixing the css settings for the AI4DSOC integrations cards so the cards
resize when the screen is narrow, instead of getting cut off.

## Screenshots

### Before
<img width="750" alt="Screenshot 2025-04-25 at 2 42 33 PM"
src="https://github.com/user-attachments/assets/2cb1033f-8998-4fd7-90ee-e7b6ce12c8ef"
/>

### After
<img width="750" alt="Screenshot 2025-04-25 at 2 39 25 PM"
src="https://github.com/user-attachments/assets/dbee50c9-2c90-455c-8dc7-f7cf102d299b"
/>

### Outside of AI4DSOC not impacted
<img width="750" alt="Screenshot 2025-04-25 at 2 33 25 PM"
src="https://github.com/user-attachments/assets/3b3961d5-4276-4da1-b046-3c8b0ac99bbe"
/>

### AI4DSOC when not narrow screen
<img width="750" alt="Screenshot 2025-04-25 at 2 50 44 PM"
src="https://github.com/user-attachments/assets/ff41c130-1691-4fae-baba-8b24e3641337"
/>

Relates
- elastic/security-team#11789
- elastic#217905

(cherry picked from commit 6516cff)

# Conflicts:
#	x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/components/package_card.tsx
kgeller added a commit that referenced this pull request Jun 4, 2025
…219306) (#222604)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[AI4DSOC] fix styling to address cutoff when screen is narrow
(#219306)](#219306)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Kylie
Meli","email":"kylie.geller@elastic.co"},"sourceCommit":{"committedDate":"2025-05-01T20:43:51Z","message":"[AI4DSOC]
fix styling to address cutoff when screen is narrow (#219306)\n\n##
Summary\n\nFixing the css settings for the AI4DSOC integrations cards so
the cards\nresize when the screen is narrow, instead of getting cut
off.\n\n## Screenshots\n\n### Before\n<img width=\"750\"
alt=\"Screenshot 2025-04-25 at 2 42
33 PM\"\nsrc=\"https://github.com/user-attachments/assets/2cb1033f-8998-4fd7-90ee-e7b6ce12c8ef\"\n/>\n\n###
After\n<img width=\"750\" alt=\"Screenshot 2025-04-25 at 2 39
25 PM\"\nsrc=\"https://github.com/user-attachments/assets/dbee50c9-2c90-455c-8dc7-f7cf102d299b\"\n/>\n\n###
Outside of AI4DSOC not impacted\n<img width=\"750\" alt=\"Screenshot
2025-04-25 at 2 33
25 PM\"\nsrc=\"https://github.com/user-attachments/assets/3b3961d5-4276-4da1-b046-3c8b0ac99bbe\"\n/>\n\n###
AI4DSOC when not narrow screen\n<img width=\"750\" alt=\"Screenshot
2025-04-25 at 2 50
44 PM\"\nsrc=\"https://github.com/user-attachments/assets/ff41c130-1691-4fae-baba-8b24e3641337\"\n/>\n\nRelates
\n- https://github.com/elastic/security-team/issues/11789\n-
https://github.com/elastic/kibana/pull/217905","sha":"6516cff1f873bbc5bbce7595e4335f2bac8aebbb","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","Team:
SecuritySolution","backport:version","v9.1.0","v8.19.0"],"title":"[AI4DSOC]
fix styling to address cutoff when screen is
narrow","number":219306,"url":"https://github.com/elastic/kibana/pull/219306","mergeCommit":{"message":"[AI4DSOC]
fix styling to address cutoff when screen is narrow (#219306)\n\n##
Summary\n\nFixing the css settings for the AI4DSOC integrations cards so
the cards\nresize when the screen is narrow, instead of getting cut
off.\n\n## Screenshots\n\n### Before\n<img width=\"750\"
alt=\"Screenshot 2025-04-25 at 2 42
33 PM\"\nsrc=\"https://github.com/user-attachments/assets/2cb1033f-8998-4fd7-90ee-e7b6ce12c8ef\"\n/>\n\n###
After\n<img width=\"750\" alt=\"Screenshot 2025-04-25 at 2 39
25 PM\"\nsrc=\"https://github.com/user-attachments/assets/dbee50c9-2c90-455c-8dc7-f7cf102d299b\"\n/>\n\n###
Outside of AI4DSOC not impacted\n<img width=\"750\" alt=\"Screenshot
2025-04-25 at 2 33
25 PM\"\nsrc=\"https://github.com/user-attachments/assets/3b3961d5-4276-4da1-b046-3c8b0ac99bbe\"\n/>\n\n###
AI4DSOC when not narrow screen\n<img width=\"750\" alt=\"Screenshot
2025-04-25 at 2 50
44 PM\"\nsrc=\"https://github.com/user-attachments/assets/ff41c130-1691-4fae-baba-8b24e3641337\"\n/>\n\nRelates
\n- https://github.com/elastic/security-team/issues/11789\n-
https://github.com/elastic/kibana/pull/217905","sha":"6516cff1f873bbc5bbce7595e4335f2bac8aebbb"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219306","number":219306,"mergeCommit":{"message":"[AI4DSOC]
fix styling to address cutoff when screen is narrow (#219306)\n\n##
Summary\n\nFixing the css settings for the AI4DSOC integrations cards so
the cards\nresize when the screen is narrow, instead of getting cut
off.\n\n## Screenshots\n\n### Before\n<img width=\"750\"
alt=\"Screenshot 2025-04-25 at 2 42
33 PM\"\nsrc=\"https://github.com/user-attachments/assets/2cb1033f-8998-4fd7-90ee-e7b6ce12c8ef\"\n/>\n\n###
After\n<img width=\"750\" alt=\"Screenshot 2025-04-25 at 2 39
25 PM\"\nsrc=\"https://github.com/user-attachments/assets/dbee50c9-2c90-455c-8dc7-f7cf102d299b\"\n/>\n\n###
Outside of AI4DSOC not impacted\n<img width=\"750\" alt=\"Screenshot
2025-04-25 at 2 33
25 PM\"\nsrc=\"https://github.com/user-attachments/assets/3b3961d5-4276-4da1-b046-3c8b0ac99bbe\"\n/>\n\n###
AI4DSOC when not narrow screen\n<img width=\"750\" alt=\"Screenshot
2025-04-25 at 2 50
44 PM\"\nsrc=\"https://github.com/user-attachments/assets/ff41c130-1691-4fae-baba-8b24e3641337\"\n/>\n\nRelates
\n- https://github.com/elastic/security-team/issues/11789\n-
https://github.com/elastic/kibana/pull/217905","sha":"6516cff1f873bbc5bbce7595e4335f2bac8aebbb"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants