Skip to content

return artifacts in the internal _resolve api#219209

Merged
mgiota merged 7 commits intoelastic:mainfrom
mgiota:artifacts_in_resolve_route
Apr 25, 2025
Merged

return artifacts in the internal _resolve api#219209
mgiota merged 7 commits intoelastic:mainfrom
mgiota:artifacts_in_resolve_route

Conversation

@mgiota
Copy link
Contributor

@mgiota mgiota commented Apr 25, 2025 •
edited
Loading

Fixes #219533

Follow up PR that addresses this comment and returns the artifacts in the internal _resolve API. The _resolve api is used in the edit rule form and fixes a UI issue in this draft PR

@mgiota mgiota force-pushed the artifacts_in_resolve_route branch from ba3b582 to 672b71c Compare April 25, 2025 10:20
@mgiota mgiota marked this pull request as ready for review April 25, 2025 10:20
@mgiota mgiota requested a review from a team as a code owner April 25, 2025 10:20
cnasikas
cnasikas approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an integration test?

@mgiota mgiota self-assigned this Apr 25, 2025
@cnasikas cnasikas added Feature:Alerting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Apr 25, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 25, 2025

Pinging @elastic/response-ops (Team:ResponseOps)

@mgiota mgiota added the release_note:skip Skip the PR/issue when compiling release notes label Apr 25, 2025
@mgiota
Copy link
Contributor Author

mgiota commented Apr 25, 2025

@elasticmachine merge upstream

@mgiota mgiota enabled auto-merge (squash) April 25, 2025 12:10
@mgiota
Copy link
Contributor Author

mgiota commented Apr 25, 2025

Could you also add an integration test?

Added in this commit

@mgiota mgiota merged commit ed2d0f8 into elastic:main Apr 25, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 25, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14668026449

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 25, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #128 / GenAI - Knowledge Base Entries APIs @ess Basic Security AI Assistant Knowledge Base Entries Create Entries Admin User should create a new document entry for the current user

Metrics [docs]

✅ unchanged

History

cc @mgiota

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 25, 2025
@mgiota @kibanamachine @elasticmachine
return artifacts in the internal _resolve api (elastic#219209)
7152e36 
Follow up PR that addresses
[this](elastic#216292 (review))
comment and returns the artifacts in the internal _resolve API. The
`_resolve` api is used in the edit rule form and fixes a UI issue in
this draft [PR](elastic#219019)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit ed2d0f8)
@kibanamachine kibanamachine mentioned this pull request Apr 25, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 25, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 25, 2025
@kibanamachine @mgiota @elasticmachine
[8.19] return artifacts in the internal _resolve api (#219209) (#219270)
70d8980 
# Backport

This will backport the following commits from `main` to `8.19`:
- [return artifacts in the internal _resolve api
(#219209)](#219209)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Panagiota
Mitsopoulou","email":"panagiota.mitsopoulou@elastic.co"},"sourceCommit":{"committedDate":"2025-04-25T15:24:28Z","message":"return
artifacts in the internal _resolve api (#219209)\n\nFollow up PR that
addresses\n[this](https://github.com/elastic/kibana/pull/216292#pullrequestreview-2783120127)\ncomment
and returns the artifacts in the internal _resolve API. The\n`_resolve`
api is used in the edit rule form and fixes a UI issue in\nthis draft
[PR](https://github.com/elastic/kibana/pull/219019)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"ed2d0f8484774ea457cd82582ccc27953d8a1a6d","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","backport:version","v9.1.0","v8.19.0"],"title":"return
artifacts in the internal _resolve
api","number":219209,"url":"https://github.com/elastic/kibana/pull/219209","mergeCommit":{"message":"return
artifacts in the internal _resolve api (#219209)\n\nFollow up PR that
addresses\n[this](https://github.com/elastic/kibana/pull/216292#pullrequestreview-2783120127)\ncomment
and returns the artifacts in the internal _resolve API. The\n`_resolve`
api is used in the edit rule form and fixes a UI issue in\nthis draft
[PR](https://github.com/elastic/kibana/pull/219019)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"ed2d0f8484774ea457cd82582ccc27953d8a1a6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219209","number":219209,"mergeCommit":{"message":"return
artifacts in the internal _resolve api (#219209)\n\nFollow up PR that
addresses\n[this](https://github.com/elastic/kibana/pull/216292#pullrequestreview-2783120127)\ncomment
and returns the artifacts in the internal _resolve API. The\n`_resolve`
api is used in the edit rule form and fixes a UI issue in\nthis draft
[PR](https://github.com/elastic/kibana/pull/219019)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"ed2d0f8484774ea457cd82582ccc27953d8a1a6d"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Panagiota Mitsopoulou <panagiota.mitsopoulou@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@mgiota @kibanamachine
@elasticmachine @akowalska622
return artifacts in the internal _resolve api (elastic#219209)
a67de38 
Follow up PR that addresses
[this](elastic#216292 (review))
comment and returns the artifacts in the internal _resolve API. The
`_resolve` api is used in the edit rule form and fixes a UI issue in
this draft [PR](elastic#219019)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mgiota mgiota deleted the artifacts_in_resolve_route branch October 1, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@mgiota mgiota

Labels

backport:version Backport to applied version labels Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

artifacts should be available in the Edit rule page/flyout

4 participants

@mgiota @elasticmachine @kibanamachine @cnasikas