[Watcher] Fix accessibility issues#219082
Merged
SoniaSanzV merged 4 commits intoelastic:mainfrom Apr 30, 2025
Merged
Conversation
SoniaSanzV
added
Feature:Watcher
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
SoniaSanzV
changed the title
alexwizp
reviewed
Apr 24, 2025
| ? JSON.stringify(watchHistoryDetails.details, null, 2) | ||
| : ''; | ||
|
|
||
| const watchHistoryDetailFlyoutId = useGeneratedHtmlId({ prefix: 'watchFlyout' }); |
Contributor
There was a problem hiding this comment.
it 100% works, but maybe we can set different values of prefix for watchHistoryDetailFlyoutId and watchHistoryErrorDetailsFlyoutTitleId ?
Contributor
Author
There was a problem hiding this comment.
Makes sense, fixed!
alexwizp
approved these changes
Apr 24, 2025
ElenaStoeva
approved these changes
Apr 30, 2025
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for fixing these a11y issues @SoniaSanzV! Changes lgtm, code review only.
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/14757019895 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @SoniaSanzV |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2025
Closes: elastic#218749 Closes: elastic#218748 **Description** Set correct label for Watcher modal and Flyouts (cherry picked from commit 7f6fcf0)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
pborgonovi
pushed a commit
that referenced
this pull request
Apr 30, 2025
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
May 5, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Watcher] Fix accessibility issues (#219082)](#219082) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-04-30T14:27:16Z","message":"[Watcher] Fix accessibility issues (#219082)\n\nCloses: https://github.com/elastic/kibana/issues/218749\nCloses: https://github.com/elastic/kibana/issues/218748\n\n**Description**\nSet correct label for Watcher modal and Flyouts","sha":"7f6fcf0fec84428afef45e947a4dfb63009519ce","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Watcher","Team:Kibana Management","release_note:skip","backport:prev-minor","v9.1.0"],"title":"[Watcher] Fix accessibility issues","number":219082,"url":"https://github.com/elastic/kibana/pull/219082","mergeCommit":{"message":"[Watcher] Fix accessibility issues (#219082)\n\nCloses: https://github.com/elastic/kibana/issues/218749\nCloses: https://github.com/elastic/kibana/issues/218748\n\n**Description**\nSet correct label for Watcher modal and Flyouts","sha":"7f6fcf0fec84428afef45e947a4dfb63009519ce"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219082","number":219082,"mergeCommit":{"message":"[Watcher] Fix accessibility issues (#219082)\n\nCloses: https://github.com/elastic/kibana/issues/218749\nCloses: https://github.com/elastic/kibana/issues/218748\n\n**Description**\nSet correct label for Watcher modal and Flyouts","sha":"7f6fcf0fec84428afef45e947a4dfb63009519ce"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <sonia.sanzvivas@elastic.co>
kibanamachine
added
v9.0.1
and removed
backport missing
Contributor
|
This PR didn't make it into the latest 9.0.1 BC. Updating the labels. |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Closes: elastic#218749 Closes: elastic#218748 **Description** Set correct label for Watcher modal and Flyouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #218749
Closes: #218748
Description
Set correct label for Watcher modal and Flyouts