-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[AI4DSOC] Hide security solution pages #219081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
0f12cd9
hide security solution pages
tomsonpl 5ca23ba
investigations
tomsonpl 1c3e040
fix notes
tomsonpl 311b2c3
fix notes v2
tomsonpl a3dfac8
Merge branch 'main' into ai-soc-dashboards
tomsonpl 77789c0
Merge branch 'main' into ai-soc-dashboards
ashokaditya fa49b26
fix explore routes
ashokaditya 1907e11
fix CSP page route
ashokaditya 6f90244
Merge branch 'main' into ai-soc-dashboards
ashokaditya 2fb226b
Merge branch 'main' into ai-soc-dashboards
ashokaditya c90bf41
review changes
ashokaditya d51e2a7
tests for visible pages
ashokaditya fe78147
tests for page redirects
ashokaditya 10bd1ed
add tests for pages that are not redirected
ashokaditya e4bba6c
Merge branch 'main' into ai-soc-dashboards
ashokaditya 2455321
fix detection rules breadcrumb
ashokaditya cf70e81
fix
ashokaditya fe377a0
Merge branch 'main' into ai-soc-dashboards
ashokaditya 9bd7656
Merge branch 'main' into ai-soc-dashboards
ashokaditya 041e97f
tests for access denied callout for ML links
ashokaditya 2703cdb
Merge branch 'main' into ai-soc-dashboards
ashokaditya 15f7c60
review changes for tests
ashokaditya 82ba336
Merge branch 'main' into ai-soc-dashboards
ashokaditya cbd965f
Merge branch 'main' into ai-soc-dashboards
ashokaditya e32b406
Merge branch 'main' into ai-soc-dashboards
ashokaditya b5b72b3
fix type check
ashokaditya 790e425
Merge branch 'main' into ai-soc-dashboards
ashokaditya 4f88971
Merge branch 'main' into ai-soc-dashboards
ashokaditya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
redirectOnMissingoption is becoming the default behaviour, which indicates that the parameter should not be necessary. We can improve the underlying logic/config.I added a task to think about it in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice!
redirectOnMissingas default behaviour makes sense.