[Search] Fix: serverless search connector types#218842
Merged
TattdCodeMonkey merged 3 commits intoelastic:mainfrom Apr 23, 2025
Merged
[Search] Fix: serverless search connector types#218842TattdCodeMonkey merged 3 commits intoelastic:mainfrom
TattdCodeMonkey merged 3 commits intoelastic:mainfrom
Conversation
TattdCodeMonkey
added
release_note:skip
Updated the content connectors config to allow disabling the management UI app without disabling the entire plugin. ES3 uses the plugin to fetch connector types, but will not use the content connectors management UIs.
Updates enterprise search and serverless search plugins to use the updated contentConnectors plugin name instead of the old searchConnectors id.
TattdCodeMonkey
force-pushed
the
fix/serverless-search-connector-types
branch
from
a78a93c to
1fe9323
Compare
TattdCodeMonkey
changed the title
YulNaumenko
approved these changes
Apr 22, 2025
Contributor
YulNaumenko
left a comment
YulNaumenko
left a comment
There was a problem hiding this comment.
LGTM. Thank you for fixing that!
Contributor
Author
|
/ci |
TinaHeiligers
approved these changes
Apr 22, 2025
Contributor
TinaHeiligers
left a comment
TinaHeiligers
left a comment
There was a problem hiding this comment.
kibana manifest changes ok.
Without tests it's hard to know if the fix works so reviewing purely from a code-owner perspective.
Contributor
⏳ Build in-progress
History
|
Contributor
Author
|
Tested this PRs image in QA and the connector types are working again: |
jeramysoucy
approved these changes
Apr 23, 2025
Contributor
jeramysoucy
left a comment
jeramysoucy
left a comment
There was a problem hiding this comment.
Kibana security changes LGTM
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary Fixes bug introduced by: elastic#213509 where serverless search & enterprise search could not load list of available connector types from the connectors plugin. This was caused by 2 things in serverless, 1) the entire plugin was disabled and 2) the plugin id was renamed. Updated the `contentConnectors` plugin to have a `ui.enabled` config value to override just disabling the management UI from being registered for Serverless Search, while still allowing the plugin to be enabled. And updated the usages of the `searchConnectors` plugin in `enteprise_search` & `serverless_search` to account for it being renamed to `contentConnectors` Of note this bug would have been caught by FTRs, but they have been skipped for being [flakey](elastic#203462) for some time, and have proven [hard fix](elastic#205971) given the current UX 😔 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes bug introduced by: #213509 where serverless search & enterprise search could not load list of available connector types from the connectors plugin. This was caused by 2 things in serverless, 1) the entire plugin was disabled and 2) the plugin id was renamed.
Updated the
contentConnectorsplugin to have aui.enabledconfig value to override just disabling the management UI from being registered for Serverless Search, while still allowing the plugin to be enabled. And updated the usages of thesearchConnectorsplugin inenteprise_search&serverless_searchto account for it being renamed tocontentConnectorsOf note this bug would have been caught by FTRs, but they have been skipped for being flakey for some time, and have proven hard fix given the current UX 😔
Checklist