Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@
"@elastic/ecs": "^8.11.5",
"@elastic/elasticsearch": "9.0.0-alpha.4",
"@elastic/ems-client": "8.6.3",
"@elastic/eui": "101.3.0",
"@elastic/eui-theme-borealis": "0.1.0",
"@elastic/eui": "101.4.0",
"@elastic/eui-theme-borealis": "0.2.0",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "^1.2.3",
"@elastic/numeral": "^2.5.1",
Expand Down
4 changes: 2 additions & 2 deletions src/dev/license_checker/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ export const LICENSE_OVERRIDES = {
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/[email protected]': ['Elastic License 2.0'],
'@elastic/eui@101.3.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'@elastic/eui-theme-borealis@0.1.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'@elastic/eui@101.4.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'@elastic/eui-theme-borealis@0.2.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'],
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
'[email protected]': ['MIT'], // license in importing module https://www.npmjs.com/package/binary
'@bufbuild/[email protected]': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/platform/test/functional/services/data_grid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ export class DataGridService extends FtrService {
}

public async getCurrentPageNumber() {
const currentPage = await this.find.byCssSelector('.euiPaginationButton[aria-current="true"]');
const currentPage = await this.find.byCssSelector('.euiPaginationButton[aria-current="page"]');
return await currentPage.getVisibleText();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -518,15 +518,15 @@ describe('DatatableComponent', () => {
expect(screen.queryByTestId('tablePaginationPopoverButton')).toBeInTheDocument();
expect(screen.getByRole('button', { name: `Page 1 of ${numberOfPages}` })).toHaveAttribute(
'aria-current',
'true'
'page'
);
const newIndex = 3;
await userEvent.click(
screen.getByRole('link', { name: `Page ${newIndex} of ${numberOfPages}` })
);
expect(
screen.getByRole('button', { name: `Page ${newIndex} of ${numberOfPages}` })
).toHaveAttribute('aria-current', 'true');
).toHaveAttribute('aria-current', 'page');
});
it('dynamically toggles pagination', async () => {
const argsWithoutPagination = copyData(args);
Expand Down Expand Up @@ -599,7 +599,7 @@ describe('DatatableComponent', () => {
);
expect(
screen.getByRole('button', { name: `Page ${newIndex} of ${numberOfPages}` })
).toHaveAttribute('aria-current', 'true');
).toHaveAttribute('aria-current', 'page');

await act(async () => {
rerender({
Expand All @@ -614,7 +614,7 @@ describe('DatatableComponent', () => {
// keeps existing page if more data is added
expect(
screen.getByRole('button', { name: `Page ${newIndex} of ${newNumberOfPages}` })
).toHaveAttribute('aria-current', 'true');
).toHaveAttribute('aria-current', 'page');
});

it('resets page position if rows change so page will be empty', async () => {
Expand All @@ -639,7 +639,7 @@ describe('DatatableComponent', () => {
);
expect(
screen.getByRole('button', { name: `Page ${newIndex} of ${numberOfPages}` })
).toHaveAttribute('aria-current', 'true');
).toHaveAttribute('aria-current', 'page');

await act(async () => {
rerender({
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading