Skip to content

[Security Solution] [Detections] Remove EQL sequence suppression feature flag#218614

Merged
dhurley14 merged 7 commits intoelastic:mainfrom
dhurley14:remove-ff-eql-seq-suppression
Apr 25, 2025
Merged

[Security Solution] [Detections] Remove EQL sequence suppression feature flag#218614
dhurley14 merged 7 commits intoelastic:mainfrom
dhurley14:remove-ff-eql-seq-suppression

Conversation

@dhurley14
Copy link
Contributor

@dhurley14 dhurley14 commented Apr 17, 2025

Summary

Removes eql sequence suppression feature flag.

Ref: #189725

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

@dhurley14 dhurley14 self-assigned this Apr 21, 2025
);
const transformer = useCallback((fields: T) => {
return fields;
}, []);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhurley14 dhurley14 added review release_note:fix v9.1.0 v8.19.0 v8.18.1 v9.0.1 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels Feature:Alert Suppression Security Solution Alert Suppression feature Team:Detection Engine Security Solution Detection Engine Area and removed release_note:fix labels Apr 21, 2025
@dhurley14 dhurley14 marked this pull request as ready for review April 21, 2025 19:02
@dhurley14 dhurley14 requested review from a team as code owners April 21, 2025 19:02
@dhurley14 dhurley14 requested review from vitaliidm and xcrzx April 21, 2025 19:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@dhurley14 dhurley14 changed the title remove feature flag [Security Solution] [Detections] Remove EQL sequence suppression feature flag Apr 21, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -493.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 91.0KB 90.9KB -45.0B

History

cc @dhurley14

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file used for? Why this fix is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cavokz This file gives us the ability to post a new rule when doing manual testing without having to go through the UI. https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/scripts/rules/queries/README.md

When I developed this feature I was using packetbeat 7.x. I think in 8.x the event category is now just network. Just for help with manual testing. These scripts have been around for a long time now.

@dhurley14 dhurley14 requested a review from cavokz April 25, 2025 10:46
Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM 👍

@dhurley14 dhurley14 merged commit b94ab4b into elastic:main Apr 25, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0

https://github.com/elastic/kibana/actions/runs/14665536669

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 25, 2025
…ure flag (elastic#218614)

## Summary

Removes eql sequence suppression feature flag.

Ref: elastic#189725
(cherry picked from commit b94ab4b)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.18 Backport failed because of merge conflicts
8.19
9.0 Backport failed because of merge conflicts

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 218614

Questions ?

Please refer to the Backport tool documentation

@dhurley14
Copy link
Contributor Author

💔 Some backports could not be created

Status Branch Result
9.0 An unhandled error occurred. Please see the logs for details
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 218614

Questions ?

Please refer to the Backport tool documentation

dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 25, 2025
…ure flag (elastic#218614)

## Summary

Removes eql sequence suppression feature flag.

Ref: elastic#189725
(cherry picked from commit b94ab4b)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/use_experimental_feature_fields_transform.ts
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Apr 25, 2025
…ure flag (elastic#218614)

## Summary

Removes eql sequence suppression feature flag.

Ref: elastic#189725
(cherry picked from commit b94ab4b)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_creation_ui/components/step_define_rule/use_experimental_feature_fields_transform.ts
#	x-pack/test/security_solution_cypress/config.ts
@dhurley14
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 25, 2025
…on feature flag (#218614) (#219244)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution] [Detections] Remove EQL sequence suppression
feature flag (#218614)](#218614)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2025-04-25T13:17:16Z","message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:Alert
Suppression","Team:Detection
Engine","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security
Solution] [Detections] Remove EQL sequence suppression feature
flag","number":218614,"url":"https://github.com/elastic/kibana/pull/218614","mergeCommit":{"message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218614","number":218614,"mergeCommit":{"message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
@yctercero
Copy link
Contributor

@nastasha-solomon this is release_note:skip but just fyi it addresses a known issue we filed in 8.18.0 about suppression still having the preview badge.

dhurley14 added a commit that referenced this pull request Apr 28, 2025
…on feature flag (#218614) (#219247)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution] [Detections] Remove EQL sequence suppression
feature flag (#218614)](#218614)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2025-04-25T13:17:16Z","message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:Alert
Suppression","Team:Detection
Engine","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security
Solution] [Detections] Remove EQL sequence suppression feature
flag","number":218614,"url":"https://github.com/elastic/kibana/pull/218614","mergeCommit":{"message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218614","number":218614,"mergeCommit":{"message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219244","number":219244,"state":"OPEN"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
dhurley14 added a commit that referenced this pull request Apr 28, 2025
…n feature flag (#218614) (#219248)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Security Solution] [Detections] Remove EQL sequence suppression
feature flag (#218614)](#218614)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2025-04-25T13:17:16Z","message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:Alert
Suppression","Team:Detection
Engine","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security
Solution] [Detections] Remove EQL sequence suppression feature
flag","number":218614,"url":"https://github.com/elastic/kibana/pull/218614","mergeCommit":{"message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218614","number":218614,"mergeCommit":{"message":"[Security
Solution] [Detections] Remove EQL sequence suppression feature flag
(#218614)\n\n## Summary\n\nRemoves eql sequence suppression feature
flag.\n\nRef:
https://github.com/elastic/kibana/pull/189725","sha":"b94ab4be02da089be85e40e8d5620dcd72126888"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219244","number":219244,"state":"OPEN"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/219247","number":219247,"state":"OPEN"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
…ure flag (elastic#218614)

## Summary

Removes eql sequence suppression feature flag.

Ref: elastic#189725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Alert Suppression Security Solution Alert Suppression feature release_note:skip Skip the PR/issue when compiling release notes review Team:Detection Engine Security Solution Detection Engine Area v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants