Skip to content

[Security Solution] Show banner to promote prebuilt rule customization in both Serverless and ESS #218540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikitaindik merged 1 commit into from
Apr 17, 2025
Merged

[Security Solution] Show banner to promote prebuilt rule customization in both Serverless and ESS #218540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D
updatePrebuiltDetectionRules: isServerless
? `${SERVERLESS_DOCS}security-prebuilt-rules-management.html#update-prebuilt-rules`
: `${SECURITY_SOLUTION_DOCS}prebuilt-rules-management.html#update-prebuilt-rules`,
prebuiltRuleCustomizationPromoBlog: isServerless
? '' // URL for Serverless to be added later, once the blog post is published. Issue: https://github.com/elastic/kibana/issues/209000
: `${ELASTIC_WEBSITE_URL}blog/security-prebuilt-rules-editing`,
prebuiltRuleCustomizationPromoBlog: `${ELASTIC_WEBSITE_URL}blog/security-prebuilt-rules-editing`,
createEsqlRuleType: `${SECURITY_SOLUTION_DOCS}rules-ui-create.html#create-esql-rule`,
ruleUiAdvancedParams: `${SECURITY_SOLUTION_DOCS}rules-ui-create.html#rule-ui-advanced-params`,
entityAnalytics: {
Expand Down
3 changes: 1 addition & 2 deletions ...ic/detections/components/callouts/blog_post_prebuilt_rule_customization_callout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { useKibana } from '../../../../common/lib/kibana';
import { BackgroundImageCallout } from '../background_image_callout';

export function BlogPostPrebuiltRuleCustomizationCallout() {
// URL is currently only available in ESS. So we are only showing this callout in ESS for now.
const blogPostUrl =
Copy link
Contributor

@maximpn maximpn Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It should be possible to move this constant out of the component.

useKibana().services.docLinks.links.securitySolution.prebuiltRuleCustomizationPromoBlog;

Expand Down Expand Up @@ -43,7 +42,7 @@ export function BlogPostPrebuiltRuleCustomizationCallout() {
dismiss(calloutMessage);
}, [dismiss, calloutMessage]);

if (blogPostUrl && isVisible(calloutMessage)) {
if (isVisible(calloutMessage)) {
return (
<>
<BackgroundImageCallout
Expand Down
2 changes: 1 addition & 1 deletion ...ections/components/callouts/blog_post_prebuilt_rule_customization_callout/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const CALLOUT_DESCRIPTION = i18n.translate(
'xpack.securitySolution.detectionEngine.blogPostPrebuiltRuleCustomizationCallout.calloutDescription',
{
defaultMessage:
'Learn how to customize prebuilt rules and update them with the latest improvements.',
'Learn how to customize prebuilt rules and update them to get the latest improvements.',
}
);

Expand Down