Skip to content

update titleManger to implement PublishesTitle and PublishesWritableTitle #218369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 1 commit into from
Apr 16, 2025
Merged

update titleManger to implement PublishesTitle and PublishesWritableTitle #218369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions ...m/packages/shared/presentation/presentation_publishing/interfaces/titles/title_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { WithAllKeys } from '../../state_manager';
import { initializeStateManager } from '../../state_manager/state_manager';
import { StateComparators, StateManager } from '../../state_manager/types';
import { PublishesWritableDescription } from './publishes_description';
import { PublishesWritableTitle } from './publishes_title';
import { PublishesTitle, PublishesWritableTitle } from './publishes_title';

export interface SerializedTitles {
title?: string;
Expand Down Expand Up @@ -41,7 +41,24 @@ export const stateHasTitles = (state: unknown): state is SerializedTitles => {

export interface TitlesApi extends PublishesWritableTitle, PublishesWritableDescription {}

// SERIALIZED STATE ONLY TODO: Convert this to an instance of src/platform/packages/shared/presentation/presentation_publishing/state_manager/state_manager.ts
export const initializeTitleManager = (
initialTitlesState: SerializedTitles
): StateManager<SerializedTitles> => initializeStateManager(initialTitlesState, defaultTitlesState);
): StateManager<SerializedTitles> & {
api: {
hideTitle$: PublishesTitle['hideTitle$'];
setHideTitle: PublishesWritableTitle['setHideTitle'];
};
} => {
const stateManager = initializeStateManager(initialTitlesState, defaultTitlesState);
return {
...stateManager,
api: {
...stateManager.api,
// SerializedTitles defines hideTitles as hidePanelTitles
// This state is persisted and this naming conflict will be resolved TBD
// add named APIs that match interface names as a work-around
hideTitle$: stateManager.api.hidePanelTitles$,
setHideTitle: stateManager.api.setHidePanelTitles,
},
};
};