[Embeddable] SLO Alerts embeddable to serialized state only#218349
[Embeddable] SLO Alerts embeddable to serialized state only#218349nickpeihl merged 8 commits intoelastic:embeddable-serialized-statefrom
Conversation
botelastic
bot
added
the
Team:actionable-obs
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
elastic-vault-github-plugin-prod
bot
requested review from
a team
as code owners
| ...titleManager.api, | ||
| ...unsavedChangesApi, | ||
| defaultTitle$, | ||
| hideTitle$: titleManager.api.hidePanelTitles$, |
There was a problem hiding this comment.
Why are hideTitle$ and setHideTitle added to the api? Title apis should be provided by ...titleManager.api,
There was a problem hiding this comment.
You should not longer need these. #218369 has resolved the issue and now provides hideTitle$ and setHideTitle in the titleManager.api
There was a problem hiding this comment.
Awesome! Thanks for updating the titleManager.
There was a problem hiding this comment.
Why all these changes to the Lens embeddable too? Are they related to the SLO Alerts ones?
There was a problem hiding this comment.
We are working on a feature branch to convert all embeddables to serialized state only. Lens has been converted but there are some eslinting errors in the branch. This PR is resolving those. Please ignore review requests on the branch. Once we get all embeddables converted and can get green CI, then we will open a PR for review. This will be in about 2 or 3 weeks time
nickpeihl
force-pushed
the
slo-alerts-sso2
branch
from
1ee4dcf to
d73aca5
Compare
_This PR does not need to be reviewed by external teams. This PR merges into a feature branch that Kibana presentation team is working on to convert the embeddable framework to only expose serialized state. Your team will be pinged for review once the work is complete and the final PR opens that merges the feature branch into main._ Updates the Field list example embeddable to serialized state only. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nickpeihl
merged commit 95c3453
into
elastic:embeddable-serialized-state
💔 Build Failed
Failed CI StepsHistory
|
5 participants
This PR does not need to be reviewed by external teams. This PR merges into a feature branch that Kibana presentation team is working on to convert the embeddable framework to only expose serialized state. Your team will be pinged for review once the work is complete and the final PR opens that merges the feature branch into main.
Summary
Converts the SLO alerts embeddable to serialized state only.
Testing this PR
Create an SLO using the "How to Test" section in the description of this PR.