decouple agg configs from vis#21827
Merged
ppisljar merged 14 commits intoelastic:masterfrom Sep 11, 2018
Merged
Conversation
ppisljar
added
WIP
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
enh/decoupleVisFromAggConfigs
branch
2 times, most recently
from
b8414c8 to
2613035
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
enh/decoupleVisFromAggConfigs
branch
from
c1625bf to
a181260
Compare
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
enh/decoupleVisFromAggConfigs
branch
from
a181260 to
19a5fd0
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
x-pack tests failled to start, other completed ok |
Contributor
Author
|
retest |
markov00
approved these changes
Aug 28, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Code LGTM. Tested on few visualization. Approved the merge after few successful build
Contributor
💔 Build Failed |
Contributor
Author
|
x-pack tests still don't start, other passed agian jenkins, test this |
Contributor
💚 Build Succeeded |
ppisljar
force-pushed
the
enh/decoupleVisFromAggConfigs
branch
from
36000e0 to
a1b87bf
Compare
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
ppisljar
force-pushed
the
enh/decoupleVisFromAggConfigs
branch
from
a1b87bf to
4f02bf0
Compare
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💔 Build Failed |
trevan
reviewed
Sep 5, 2018
| } | ||
| return value === 'number'; | ||
| }, | ||
| filterFieldTypes: '*', |
Contributor
There was a problem hiding this comment.
This change looks like top_hit is now different. Before, you could only see number fields if the vis wasn't a table or a metric.
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Sep 11, 2018
ppisljar
added a commit
that referenced
this pull request
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes vis dependency from AggConfigs, AggConfig and AggTypes
The above classes are used to construct elasticsearch requests and should not have any dependency on the visualization.
preparation for #19813
this also resolves #22879
QA: No functionality has changed