[8.x] [FTR] unify custom role name with Scout (#217882)#218260
Merged
dmlemeshko merged 1 commit intoelastic:8.xfrom Apr 15, 2025
Merged
[8.x] [FTR] unify custom role name with Scout (#217882)#218260dmlemeshko merged 1 commit intoelastic:8.xfrom
dmlemeshko merged 1 commit intoelastic:8.xfrom
Conversation
## Summary
In QAF David added a possibility to spin up MKI project with custom role
set and ready to use.
Originally FTR was using reserved name `'customRole'` for internal
Kibana role to be mapped with native custom role in the project.
Both Scout and FTR use `kbn/test` to simulate SAML authentication, but
the new framework will allow to run the tests in parallel. That said, we
need to support multiple custom role credentials (one pair per worker)
and for simplicity we decided to use the same keys:
To run your tests locally against MKI you need to add a new Cloud user
entry in `user_roles.json`:
```
"custom_role_worker_1": { "username": ..., "password": ... }, // FTR requires only the first entry
"custom_role_worker_2": { "username": ..., "password": ... },
...
```
The test change is minimal:
<img width="559" alt="image"
src="https://github.com/user-attachments/assets/572103a3-13b2-4e6c-b9d2-5e55b03ac51c"
/>
---------
Co-authored-by: Cesare de Cal <cesare.decal@elastic.co>
(cherry picked from commit c4a97e5)
# Conflicts:
# x-pack/test/spaces_api_integration/deployment_agnostic/services/role_scoped_supertest.ts
csr
approved these changes
Apr 15, 2025
Contributor
csr
left a comment
csr
left a comment
There was a problem hiding this comment.
@dmlemeshko I am comparing this PR with #217882 and I don't see the change to the role_scoped_supertest.ts file here. It looks like the file was introduced by #200606 in v9.0.0, so that is expected. LGTM!
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation