Skip to content

[Obs AI Assistant]fixing error - Display results and Visualize query Bedrock Error #218213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturoliduena merged 2 commits into from
Apr 21, 2025
Merged

[Obs AI Assistant]fixing error - Display results and Visualize query Bedrock Error #218213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cae469f
[Obs AI Assistant]fixing error - Display results and Visualize query …
arturoliduena Apr 15, 2025
95b8824
Merge branch 'main' into obs-ai-assistant-214005-Display-results-and-…
arturoliduena Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 64 additions & 65 deletions x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,75 +291,74 @@ export function ChatBody({
}
});

const handleActionClick = ({
message,
payload,
}: {
message: Message;
payload: ChatActionClickPayload;
}) => {
setStickToBottom(true);
switch (payload.type) {
case ChatActionClickType.executeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
name: 'execute_query',
arguments: JSON.stringify({
query: payload.query,
}),
trigger: MessageRole.User,
const handleActionClick = useCallback(
({ message, payload }: { message: Message; payload: ChatActionClickPayload }) => {
setStickToBottom(true);
switch (payload.type) {
case ChatActionClickType.executeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
name: 'execute_query',
arguments: JSON.stringify({
query: payload.query,
}),
trigger: MessageRole.User,
},
},
},
})
);
break;

case ChatActionClickType.updateVisualization:
const visualizeQueryResponse = message;

const visualizeQueryResponseData = JSON.parse(visualizeQueryResponse.message.data ?? '{}');

next(
messages.slice(0, messages.indexOf(visualizeQueryResponse)).concat({
'@timestamp': new Date().toISOString(),
message: {
name: 'visualize_query',
content: visualizeQueryResponse.message.content,
data: JSON.stringify({
...visualizeQueryResponseData,
userOverrides: payload.userOverrides,
}),
role: MessageRole.User,
},
})
);
break;
case ChatActionClickType.visualizeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
})
);
break;

case ChatActionClickType.updateVisualization:
const visualizeQueryResponse = message;

const visualizeQueryResponseData = JSON.parse(
visualizeQueryResponse.message.data ?? '{}'
);

next(
messages.slice(0, messages.indexOf(visualizeQueryResponse)).concat({
'@timestamp': new Date().toISOString(),
message: {
name: 'visualize_query',
arguments: JSON.stringify({
query: payload.query,
intention: VisualizeESQLUserIntention.visualizeAuto,
content: visualizeQueryResponse.message.content,
data: JSON.stringify({
...visualizeQueryResponseData,
userOverrides: payload.userOverrides,
}),
trigger: MessageRole.User,
role: MessageRole.User,
},
},
})
);
break;
}
};
})
);
break;
case ChatActionClickType.visualizeEsqlQuery:
next(
messages.concat({
'@timestamp': new Date().toISOString(),
message: {
role: MessageRole.Assistant,
content: '',
function_call: {
name: 'visualize_query',
arguments: JSON.stringify({
query: payload.query,
intention: VisualizeESQLUserIntention.visualizeAuto,
}),
trigger: MessageRole.User,
},
},
})
);
break;
}
},
[messages, next]
);

const handleConversationAccessUpdate = async (access: ConversationAccess) => {
await updateConversationAccess(access);
Expand Down
10 changes: 3 additions & 7 deletions ...lugins/shared/observability_ai_assistant/public/components/message_panel/message_text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
import { css } from '@emotion/css';
import classNames from 'classnames';
import type { Code, InlineCode, Parent, Text } from 'mdast';
import React, { useMemo, useRef } from 'react';
import React, { useMemo } from 'react';
import type { Node } from 'unist';
import { ChatActionClickHandler } from '../chat/types';
import { CodeBlock, EsqlCodeBlock } from './esql_code_block';
Expand Down Expand Up @@ -120,10 +120,6 @@ export function MessageText({ loading, content, onActionClick }: Props) {
overflow-wrap: anywhere;
`;

const onActionClickRef = useRef(onActionClick);

onActionClickRef.current = onActionClick;

const { parsingPluginList, processingPluginList } = useMemo(() => {
const parsingPlugins = getDefaultEuiMarkdownParsingPlugins();

Expand All @@ -149,7 +145,7 @@ export function MessageText({ loading, content, onActionClick }: Props) {
value={props.value}
lang={props.lang}
actionsDisabled={loading}
onActionClick={onActionClickRef.current}
onActionClick={onActionClick}
/>
<EuiSpacer size="m" />
</>
Expand Down Expand Up @@ -187,7 +183,7 @@ export function MessageText({ loading, content, onActionClick }: Props) {
parsingPluginList: [loadingCursorPlugin, esqlLanguagePlugin, ...parsingPlugins],
processingPluginList: processingPlugins,
};
}, [loading]);
}, [loading, onActionClick]);

return (
<EuiText size="s" className={containerClassName}>
Expand Down
Loading