[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form#218195
Merged
parkiino merged 8 commits intoelastic:mainfrom May 2, 2025
Conversation
parkiino
added
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
1 task
parkiino
requested review from
a team,
paul-tavares and
pzl
and removed request for
a team
nikitaindik
approved these changes
Apr 15, 2025
Contributor
nikitaindik
left a comment
nikitaindik
left a comment
There was a problem hiding this comment.
LGTM from the Rules Management since this code is not used on our pages. I haven't tested it locally, just looked at the code changes.
As a side note, might be a good idea to add a test to index.test.ts to verify correctness.
ashokaditya
reviewed
Apr 16, 2025
| return filePathRegex.test(value); | ||
| } | ||
| return /^(\/|(\/[\w\-]+)+|\/[\w\-]+\.[\w]+|(\/[\w-]+)+\/[\w\-]+\.[\w]+)$/i.test(value); | ||
| return /^((\/[\w\-]+)+|\/[\w\-]+\.[\w]+|(\/[\w-]+)+\/[\w\-]+\.[\w]+)$/i.test(value); |
Member
There was a problem hiding this comment.
This regex should not be changed.
ashokaditya
requested changes
Apr 16, 2025
Member
There was a problem hiding this comment.
/ is a valid unix path so the issue is not with the regex like we were discussing offline. We need to expand the conditions that show the warning.
rylnd
approved these changes
Apr 21, 2025
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Approving so as not to block here, but it looks like @ashokaditya's concerns about the regex trump any input I could have here.
parkiino
added
backport:prev-major
and removed
backport:skip
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/14803886439 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2025
…mac and linux in trusted apps form (elastic#218195) ## Summary - [x] This corrects a bug where the "wildcard warning" would be shown instead of the "invalid path warning" if a user tried to create a trusted app with a mac or linux OS and with the path condition field and value of `/`. Note: Although `/` may be a valid path as in `ls /`, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path. # Screenshots <img width="807" alt="image" src="https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42" /> <img width="811" alt="image" src="https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1" /> (cherry picked from commit 3e67e7a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2025
…mac and linux in trusted apps form (elastic#218195) ## Summary - [x] This corrects a bug where the "wildcard warning" would be shown instead of the "invalid path warning" if a user tried to create a trusted app with a mac or linux OS and with the path condition field and value of `/`. Note: Although `/` may be a valid path as in `ls /`, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path. # Screenshots <img width="807" alt="image" src="https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42" /> <img width="811" alt="image" src="https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1" /> (cherry picked from commit 3e67e7a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2025
…mac and linux in trusted apps form (elastic#218195) ## Summary - [x] This corrects a bug where the "wildcard warning" would be shown instead of the "invalid path warning" if a user tried to create a trusted app with a mac or linux OS and with the path condition field and value of `/`. Note: Although `/` may be a valid path as in `ls /`, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path. # Screenshots <img width="807" alt="image" src="https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42" /> <img width="811" alt="image" src="https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1" /> (cherry picked from commit 3e67e7a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2025
…mac and linux in trusted apps form (elastic#218195) ## Summary - [x] This corrects a bug where the "wildcard warning" would be shown instead of the "invalid path warning" if a user tried to create a trusted app with a mac or linux OS and with the path condition field and value of `/`. Note: Although `/` may be a valid path as in `ls /`, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path. # Screenshots <img width="807" alt="image" src="https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42" /> <img width="811" alt="image" src="https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1" /> (cherry picked from commit 3e67e7a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 2, 2025
…ug for mac and linux in trusted apps form (#218195) (#220013) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)](#218195) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-02T21:44:43Z","message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form","number":218195,"url":"https://github.com/elastic/kibana/pull/218195","mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218195","number":218195,"mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}}]}] BACKPORT--> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
May 2, 2025
…ug for mac and linux in trusted apps form (#218195) (#220014) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)](#218195) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-02T21:44:43Z","message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form","number":218195,"url":"https://github.com/elastic/kibana/pull/218195","mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218195","number":218195,"mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}}]}] BACKPORT--> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
May 2, 2025
…ug for mac and linux in trusted apps form (#218195) (#220012) # Backport This will backport the following commits from `main` to `8.17`: - [[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)](#218195) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-02T21:44:43Z","message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form","number":218195,"url":"https://github.com/elastic/kibana/pull/218195","mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218195","number":218195,"mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}}]}] BACKPORT--> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
May 5, 2025
…g for mac and linux in trusted apps form (#218195) (#220015) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)](#218195) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-02T21:44:43Z","message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form","number":218195,"url":"https://github.com/elastic/kibana/pull/218195","mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218195","number":218195,"mergeCommit":{"message":"[Security Solution][Admin][Trusted Apps] Fixes wrong warning bug for mac and linux in trusted apps form (#218195)\n\n## Summary\n\n- [x] This corrects a bug where the \"wildcard warning\" would be shown\ninstead of the \"invalid path warning\" if a user tried to create a\ntrusted app with a mac or linux OS and with the path condition field and\nvalue of `/`.\n\nNote: Although `/` may be a valid path as in `ls /`, the path value\nexpected in trusted apps and other exceptions items expect a path to an\nexecutable as opposed to a simple directory path.\n\n# Screenshots\n<img width=\"807\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42\"\n/>\n\n\n<img width=\"811\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1\"\n/>","sha":"3e67e7a670694284345f96fbbd56da446aa07c85"}}]}] BACKPORT--> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
This PR didn't make it into the latest 8.18.1, 8.17.6 and 9.0.1 BC. Updating the labels. |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…mac and linux in trusted apps form (elastic#218195) ## Summary - [x] This corrects a bug where the "wildcard warning" would be shown instead of the "invalid path warning" if a user tried to create a trusted app with a mac or linux OS and with the path condition field and value of `/`. Note: Although `/` may be a valid path as in `ls /`, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path. # Screenshots <img width="807" alt="image" src="https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42" /> <img width="811" alt="image" src="https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1" />
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…mac and linux in trusted apps form (elastic#218195) ## Summary - [x] This corrects a bug where the "wildcard warning" would be shown instead of the "invalid path warning" if a user tried to create a trusted app with a mac or linux OS and with the path condition field and value of `/`. Note: Although `/` may be a valid path as in `ls /`, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path. # Screenshots <img width="807" alt="image" src="https://github.com/user-attachments/assets/fc320a85-0bb8-4d26-97f2-f3dc9a89cc42" /> <img width="811" alt="image" src="https://github.com/user-attachments/assets/f3d99754-79a8-4734-8858-521f6e0778a1" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/.Note: Although
/may be a valid path as inls /, the path value expected in trusted apps and other exceptions items expect a path to an executable as opposed to a simple directory path.Screenshots