Skip to content

[9.0] [Console] Fix output for empty response body (#218104) #218185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 5 commits into from
Apr 17, 2025
Merged

[9.0] [Console] Fix output for empty response body (#218104) #218185

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c93a51d
[Console] Fix output for empty response body (#218104)
ElenaStoeva Apr 14, 2025
1e33582
Merge branch '9.0' into backport/9.0/pr-218104
ElenaStoeva Apr 15, 2025
5d51733
Fix output for non-empty body
ElenaStoeva Apr 16, 2025
0967b68
Merge branch '9.0' into backport/9.0/pr-218104
ElenaStoeva Apr 16, 2025
341d021
Merge branch '9.0' into backport/9.0/pr-218104
ElenaStoeva Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .../plugins/shared/console/public/application/hooks/use_send_current_request/send_request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,13 @@ export function sendRequest(args: RequestArgs): Promise<RequestResult[]> {

if (response) {
let value;
if (statusCode === 200 && !body) {
// If the request resolves with a 200 status code but has an empty or null body,
// we should still display a success message to the user.
value = 'OK';
}
// check if object is ArrayBuffer
if (body instanceof ArrayBuffer) {
else if (body instanceof ArrayBuffer) {
value = body;
} else {
value = typeof body === 'string' ? body : JSON.stringify(body, null, 2);
Expand Down Expand Up @@ -157,18 +162,12 @@ export function sendRequest(args: RequestArgs): Promise<RequestResult[]> {

const { statusCode, statusText } = extractStatusCodeAndText(response, path);

// When the request is sent, the HTTP library tries to parse the response body as JSON.
// However, if the response body is empty or not in valid JSON format, it throws an error.
// To handle this, if the request resolves with a 200 status code but has an empty or invalid body,
// we should still display a success message to the user.
if (statusCode === 200 && body === null) {
if (statusCode === 200 && !body) {
value = 'OK';
} else if (body) {
value = JSON.stringify(body, null, 2);
} else {
if (body) {
value = JSON.stringify(body, null, 2);
} else {
value = 'Request failed to get to the server (status code: ' + statusCode + ')';
}
value = 'Request failed to get to the server (status code: ' + statusCode + ')';
}

if (isMultiRequest) {
Expand Down