[ES|QL] fix editor menus on safari#218167
Merged
drewdaemon merged 29 commits intoelastic:mainfrom Apr 15, 2025
Merged
Conversation
drewdaemon
added
v9.1.0
v8.19.0
backport:version
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
reviewed
Apr 15, 2025
Contributor
There was a problem hiding this comment.
Are there any changes here? 🤔
Contributor
Author
There was a problem hiding this comment.
IDE being "helpful"
stratoula
approved these changes
Apr 15, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
I managed to repro and test the fix.
Apparently if you go from Discover to dashbards it works as expected but if you go to the Dashboards directly then it doesnt
Regardless, this is fixing it. Awesome Drew! LGTM
(I think the changes you did in the _app.scss are just linting things. I suggest to revert them (it won't need the design review either)
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14477750588 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 15, 2025
## Summary Fix elastic#215405 Tooltips still work: <img width="524" alt="Screenshot 2025-04-14 at 1 03 17 PM" src="https://github.com/user-attachments/assets/5a28d2e4-af75-455f-9df1-691493460cc7" /> --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit 7ee7edb)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] fix editor menus on safari (#218167)](#218167) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-04-15T19:26:27Z","message":"[ES|QL] fix editor menus on safari (#218167)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/215405\n\nTooltips still work:\n\n<img width=\"524\" alt=\"Screenshot 2025-04-14 at 1 03 17 PM\"\nsrc=\"https://github.com/user-attachments/assets/5a28d2e4-af75-455f-9df1-691493460cc7\"\n/>\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"7ee7edb5e5165f4537659f271e604528807415b3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] fix editor menus on safari","number":218167,"url":"https://github.com/elastic/kibana/pull/218167","mergeCommit":{"message":"[ES|QL] fix editor menus on safari (#218167)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/215405\n\nTooltips still work:\n\n<img width=\"524\" alt=\"Screenshot 2025-04-14 at 1 03 17 PM\"\nsrc=\"https://github.com/user-attachments/assets/5a28d2e4-af75-455f-9df1-691493460cc7\"\n/>\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"7ee7edb5e5165f4537659f271e604528807415b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218167","number":218167,"mergeCommit":{"message":"[ES|QL] fix editor menus on safari (#218167)\n\n## Summary\n\nFix https://github.com/elastic/kibana/issues/215405\n\nTooltips still work:\n\n<img width=\"524\" alt=\"Screenshot 2025-04-14 at 1 03 17 PM\"\nsrc=\"https://github.com/user-attachments/assets/5a28d2e4-af75-455f-9df1-691493460cc7\"\n/>\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"7ee7edb5e5165f4537659f271e604528807415b3"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #215405
Tooltips still work: