[8.x] NavigationItemOpenPanel: remove handling of landing page ("four squares" design) (#210893)#218133
Merged
tsullivan merged 2 commits intoelastic:8.xfrom Apr 15, 2025
Merged
Conversation
…es" design) (elastic#210893) ## Summary Part of Epic: elastic/kibana-team#1439 Requires: elastic#212903 Changes: 1. Moves the Solution Side Nav away from the "four squares" design pattern: where clicking the item label opens a landing page and the item icon opens the secondary nav panel. This was a custom component implemented in the Kibana package, not part of the EUI `EuiCollapsibleNavBeta` component. 2. Changes some usage of `@emotion/css` to `@emotion/react` for better developer experience ### Screenshots <details><summary>Before</summary>  </details> <details><summary>After</summary>  </details> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] This design pattern was only used in Security Solution. There is a small risk of regression issues in Security Solution navigation. This was mitigated by manual testing during development. (cherry picked from commit 77523f7) # Conflicts: # x-pack/test/security_solution_cypress/cypress/e2e/explore/navigation/navigation.cy.ts
botelastic
bot
added
the
ci:project-deploy-observability
3 tasks
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
⏳ Build in-progress
History
|
Dosant
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation