Skip to content

Comments

Fix/lens serialize#218082

Merged
ppisljar merged 4 commits intoelastic:mainfrom
ppisljar:fix/lens_serialize
Apr 15, 2025
Merged

Fix/lens serialize#218082
ppisljar merged 4 commits intoelastic:mainfrom
ppisljar:fix/lens_serialize

Conversation

@ppisljar
Copy link
Contributor

@ppisljar ppisljar commented Apr 14, 2025

Summary

resolves #218079 by properly serializing appliedTimeRange

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@ppisljar ppisljar added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.0.1 labels Apr 14, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 400.0KB 400.1KB +96.0B

History

@ppisljar ppisljar marked this pull request as ready for review April 14, 2025 13:20
@ppisljar ppisljar requested review from a team as code owners April 14, 2025 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ppisljar ppisljar merged commit 1017c22 into elastic:main Apr 15, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14465254340

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 15, 2025
(cherry picked from commit 1017c22)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.x
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Expression] Cached expression can keep their own side effects (#216519)

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 218082

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 15, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix/lens serialize
(#218082)](#218082)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Peter
Pisljar","email":"peter.pisljar@elastic.co"},"sourceCommit":{"committedDate":"2025-04-15T08:48:43Z","message":"Fix/lens
serialize
(#218082)","sha":"1017c22245e4d6a262480bc85c7502ad4d5432d5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"Fix/lens
serialize","number":218082,"url":"https://github.com/elastic/kibana/pull/218082","mergeCommit":{"message":"Fix/lens
serialize
(#218082)","sha":"1017c22245e4d6a262480bc85c7502ad4d5432d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218082","number":218082,"mergeCommit":{"message":"Fix/lens
serialize
(#218082)","sha":"1017c22245e4d6a262480bc85c7502ad4d5432d5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Peter Pisljar <peter.pisljar@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discover logs an error in console when using esql stats by datehistogram

5 participants