A11y - updating highlighting on surrounded documents UI#218066
Merged
l-suarez merged 16 commits intoelastic:mainfrom Apr 24, 2025
Merged
A11y - updating highlighting on surrounded documents UI#218066l-suarez merged 16 commits intoelastic:mainfrom
l-suarez merged 16 commits intoelastic:mainfrom
Conversation
l-suarez
added
Feature:Discover
Contributor
Author
|
/ci |
…' of https://github.com/l-suarez/kibana into a11y---Updating-highlighting-on-surrounded-documents-UI
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
akowalska622
approved these changes
Apr 24, 2025
Contributor
akowalska622
left a comment
akowalska622
left a comment
There was a problem hiding this comment.
LGTM, great work @l-suarez! 🥳
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @l-suarez |
akowalska622
added a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary Updating color tokens on anchored documents in Discover to comply with accessibility recommendations. We're also the using a yellow highlight (background-base-warning) and adjusted how the anchor document name appears at the top, using text-warning + bg-base-warning to clearly highlight the meaning of this yellow highlight. Closes elastic#213052  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ania Kowalska <63072419+akowalska622@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating color tokens on anchored documents in Discover to comply with accessibility recommendations. We're also the using a yellow highlight (background-base-warning) and adjusted how the anchor document name appears at the top, using text-warning + bg-base-warning to clearly highlight the meaning of this yellow highlight.
Closes #213052
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelines