Skip to content

Comments

Reorganize footer items for Solutions#218050

Merged
tsullivan merged 16 commits intoelastic:mainfrom
tsullivan:sidenav/footer-structure-fixes
May 2, 2025
Merged

Reorganize footer items for Solutions#218050
tsullivan merged 16 commits intoelastic:mainfrom
tsullivan:sidenav/footer-structure-fixes

Conversation

@tsullivan
Copy link
Member

@tsullivan tsullivan commented Apr 14, 2025 •
edited by kibanamachine
Loading

Summary

Epic: https://github.com/elastic/kibana-team/issues/1439
Depends on #218156

Addresses footer issues and a few content issues

side.nav.footer.structure.fixes.-.01.mp4
  1. Footer item texts should not be bold
  2. We should have the spacing of regular nav sub-items in the footer

Other fixes:

  1. Fix text casing in "Machine Learning" (Note: other casing issues exist)
  2. Remove recentlyAccessed sections

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@tsullivan tsullivan force-pushed the sidenav/footer-structure-fixes branch from 17a3414 to c74259e Compare April 14, 2025 05:43
@tsullivan tsullivan mentioned this pull request Apr 14, 2025
Merged
2 tasks
@tsullivan tsullivan force-pushed the sidenav/footer-structure-fixes branch 2 times, most recently from aa3ee6b to 1f5eed6 Compare April 15, 2025 01:33
@tsullivan tsullivan marked this pull request as ready for review April 15, 2025 04:33
@tsullivan tsullivan requested review from a team as code owners April 15, 2025 04:33
@tsullivan tsullivan marked this pull request as draft April 15, 2025 04:33
tsullivan added a commit that referenced this pull request Apr 15, 2025
@tsullivan
[Solution Side Nav] Remove PanelContentProvider & support optional ti…
b9c2b57 
…tle in nav node (#218156)

Epic: elastic/kibana-team#1439
Needed for #218050 (adjustments to
types for `title` field in `ChromeProjectNavigationNode`)

## Summary

1. `PanelContentProvider` was used for security solution, but is no
longer used. This removes it to simplify the interfaces for panel .
2. Allow title of `navGroup` to be optional. This allows the correct
design for nav items in the footer, which are child-items of a nav group
with no title

## Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 15, 2025
@tsullivan
[Solution Side Nav] Remove PanelContentProvider & support optional ti…
aa6261f 
…tle in nav node (elastic#218156)

Epic: elastic/kibana-team#1439
Needed for elastic#218050 (adjustments to
types for `title` field in `ChromeProjectNavigationNode`)

## Summary

1. `PanelContentProvider` was used for security solution, but is no
longer used. This removes it to simplify the interfaces for panel .
2. Allow title of `navGroup` to be optional. This allows the correct
design for nav items in the footer, which are child-items of a nav group
with no title

## Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit b9c2b57)
@tsullivan tsullivan force-pushed the sidenav/footer-structure-fixes branch 4 times, most recently from 4ed39de to cd4e382 Compare April 16, 2025 00:52
tsullivan added a commit that referenced this pull request Apr 16, 2025
@tsullivan
[8.x] [Solution Side Nav] Remove PanelContentProvider & support optio…
a12abe9 
…nal title in nav node (#218156) (#218330)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Solution Side Nav] Remove PanelContentProvider & support optional
title in nav node
(#218156)](#218156)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-15T15:04:01Z","message":"[Solution
Side Nav] Remove PanelContentProvider & support optional title in nav
node (#218156)\n\nEpic:
https://github.com/elastic/kibana-team/issues/1439\nNeeded for
#218050 (adjustments to\ntypes for
`title` field in `ChromeProjectNavigationNode`)\n\n## Summary\n\n1.
`PanelContentProvider` was used for security solution, but is no\nlonger
used. This removes it to simplify the interfaces for panel .\n2. Allow
title of `navGroup` to be optional. This allows the correct\ndesign for
nav items in the footer, which are child-items of a nav group\nwith no
title\n\n## Checklist\n\nCheck the PR satisfies following conditions.
\n\nReviewers should verify this PR satisfies this list as well.\n\n-
[x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"b9c2b57c23d1d74d4fef025d64b820216ddce272","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:SharedUX","backport:version","v9.1.0","v8.19.0"],"title":"[Solution
Side Nav] Remove PanelContentProvider & support optional title in nav
node","number":218156,"url":"https://github.com/elastic/kibana/pull/218156","mergeCommit":{"message":"[Solution
Side Nav] Remove PanelContentProvider & support optional title in nav
node (#218156)\n\nEpic:
https://github.com/elastic/kibana-team/issues/1439\nNeeded for
#218050 (adjustments to\ntypes for
`title` field in `ChromeProjectNavigationNode`)\n\n## Summary\n\n1.
`PanelContentProvider` was used for security solution, but is no\nlonger
used. This removes it to simplify the interfaces for panel .\n2. Allow
title of `navGroup` to be optional. This allows the correct\ndesign for
nav items in the footer, which are child-items of a nav group\nwith no
title\n\n## Checklist\n\nCheck the PR satisfies following conditions.
\n\nReviewers should verify this PR satisfies this list as well.\n\n-
[x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"b9c2b57c23d1d74d4fef025d64b820216ddce272"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218156","number":218156,"mergeCommit":{"message":"[Solution
Side Nav] Remove PanelContentProvider & support optional title in nav
node (#218156)\n\nEpic:
https://github.com/elastic/kibana-team/issues/1439\nNeeded for
#218050 (adjustments to\ntypes for
`title` field in `ChromeProjectNavigationNode`)\n\n## Summary\n\n1.
`PanelContentProvider` was used for security solution, but is no\nlonger
used. This removes it to simplify the interfaces for panel .\n2. Allow
title of `navGroup` to be optional. This allows the correct\ndesign for
nav items in the footer, which are child-items of a nav group\nwith no
title\n\n## Checklist\n\nCheck the PR satisfies following conditions.
\n\nReviewers should verify this PR satisfies this list as well.\n\n-
[x]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"b9c2b57c23d1d74d4fef025d64b820216ddce272"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@tsullivan tsullivan force-pushed the sidenav/footer-structure-fixes branch from cd4e382 to 45fc74e Compare April 17, 2025 22:39
ek-so
ek-so requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@ek-so ek-so left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim! I guess we have some problems with vertical spacing now, between the divider and the edge of the item:
CleanShot 2025-04-22 at 11 50 13@2x
s/dd099a8c-95b6-4d54-b4cd-e2bd12a03942)

We should still keep some space between them:
CleanShot 2025-04-22 at 11 51 01@2x
CleanShot 2025-04-22 at 11 53 22@2x

@tsullivan tsullivan force-pushed the sidenav/footer-structure-fixes branch from 45fc74e to 8da0772 Compare April 24, 2025 00:19
@tsullivan tsullivan mentioned this pull request Apr 24, 2025
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 30, 2025 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.2MB 1.2MB +56.0B
navigation 20.3KB 20.6KB +341.0B
observability 1.3MB 1.3MB +33.0B
serverless 21.0KB 21.4KB +341.0B
total +771.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionEss 30.5KB 30.5KB +55.0B
securitySolutionServerless 43.6KB 43.7KB +91.0B
serverlessChat 4.4KB 4.4KB +26.0B
serverlessObservability 13.6KB 13.7KB +33.0B
serverlessSearch 26.1KB 26.1KB +67.0B
total +272.0B

History

@tsullivan tsullivan merged commit ee74bb4 into elastic:main May 2, 2025
11 checks passed
@tsullivan tsullivan deleted the sidenav/footer-structure-fixes branch May 2, 2025 14:51
@kibanamachine
Copy link
Contributor

kibanamachine commented May 2, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14797586047

@kibanamachine
Copy link
Contributor

kibanamachine commented May 2, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 218050

Questions ?

Please refer to the Backport tool documentation

This was referenced May 2, 2025
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented May 6, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 218050 locally
cc: @tsullivan

@tsullivan
Copy link
Member Author

tsullivan commented May 6, 2025

Removing the backport labels from this. My understanding is this is not backportable because of the EUI theme tokens being used.

@tsullivan tsullivan added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels May 6, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2025
@tsullivan tsullivan added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed v8.19.0 labels May 6, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2025
@tsullivan tsullivan mentioned this pull request May 9, 2025
Closed
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@tsullivan @akowalska622
Reorganize footer items for Solutions (elastic#218050)
2ee4118 
## Summary

Epic: elastic/kibana-team#1439
~Depends on elastic#218156

Addresses footer issues and a few content issues


https://github.com/user-attachments/assets/07063aa7-8a49-4cb5-9fd2-a6e1cbd674b7


1. Footer item texts should not be bold
2. We should have the spacing of regular nav sub-items in the footer

Other fixes:
1. Fix text casing in "Machine Learning" (Note: [other casing issues
exist](elastic#217352))
2. Remove `recentlyAccessed` sections

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@semd semd added backport:version Backport to applied version labels v8.19.0 and removed backport:skip This PR does not require backporting labels May 30, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented May 30, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15349053230

@kibanamachine
Copy link
Contributor

kibanamachine commented May 30, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15349053195

@kibanamachine
Copy link
Contributor

kibanamachine commented May 30, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 218050

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented May 30, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 218050

Questions ?

Please refer to the Backport tool documentation

@semd semd added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels v8.19.0 labels May 30, 2025
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@tsullivan @qn895
Reorganize footer items for Solutions (elastic#218050)
f0f4840 
## Summary

Epic: elastic/kibana-team#1439
~Depends on elastic#218156

Addresses footer issues and a few content issues


https://github.com/user-attachments/assets/07063aa7-8a49-4cb5-9fd2-a6e1cbd674b7


1. Footer item texts should not be bold
2. We should have the spacing of regular nav sub-items in the footer

Other fixes:
1. Fix text casing in "Machine Learning" (Note: [other casing issues
exist](elastic#217352))
2. Remove `recentlyAccessed` sections

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@pheyos pheyos pheyos approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@semd semd semd approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

@ek-so ek-so ek-so approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.