Skip to content

[Discover] Fix flaky test #217012 #218021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davismcphee merged 2 commits into from
Apr 14, 2025
Merged

[Discover] Fix flaky test #217012 #218021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ef462c
Try fixing flaky functional test
davismcphee Apr 11, 2025
df24285
Merge branch 'main' into fix-flaky-test-217012
davismcphee Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/platform/test/functional/apps/discover/group1/_discover_accessibility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.savedObjects.clean({ types: ['search', 'index-pattern'] });
});

// FLAKY: https://github.com/elastic/kibana/issues/217012
describe.skip('top nav menu buttons', () => {
describe('top nav menu buttons', () => {
const focusAndPressButton = async (buttonTestSubject: string | WebElementWrapper) => {
const button =
typeof buttonTestSubject === 'string'
Expand All @@ -68,7 +67,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await retry.try(async () => {
expect(await hasFocus(menuButtonTestSubject)).to.be(false);
});

// Small delay to allow the overlay to open fully
await new Promise((resolve) => setTimeout(resolve, 500));
await browser.pressKeys(browser.keys.ESCAPE);
await retry.try(async () => {
expect(await hasFocus(menuButtonTestSubject)).to.be(true);
Expand Down