chore(NA): updating used polyfills using 3rd party library

package.json

@@ -93,7 +93,7 @@
     "**/remark-parse/trim": "1.0.1",
     "**/sharp": "0.32.6",
     "**/typescript": "5.1.6",
-    "**/util": "^0.11.1",
+    "**/util": "^0.12.5",
     "@aws-sdk/client-bedrock-agent-runtime": "^3.744.0",
     "@aws-sdk/client-bedrock-runtime": "^3.744.0",
     "@aws-sdk/client-kendra": "3.744.0",
@@ -1852,7 +1852,7 @@
     "msw": "~2.7.4",
     "mutation-observer": "^1.0.3",
     "nock": "12.0.3",
-    "node-libs-browser": "^2.2.1",
+    "node-stdlib-browser": "^1.3.1",
     "nyc": "^17.1.0",
     "oboe": "^2.1.7",
     "openapi-types": "^12.1.3",

packages/kbn-optimizer/src/worker/webpack.config.ts

@@ -295,6 +295,14 @@ export function getWebpackConfig(
         vega: Path.resolve(worker.repoRoot, 'node_modules/vega/build-es5/vega.js'),
         'react-dom$': 'react-dom/profiling',
         'scheduler/tracing': 'scheduler/tracing-profiling',
+        buffer: [
+          Path.resolve(worker.repoRoot, 'node_modules/node-stdlib-browser/node_modules/buffer'),
+          require.resolve('buffer'),
+        ],
+        punycode: [
+          Path.resolve(worker.repoRoot, 'node_modules/node-stdlib-browser/node_modules/punycode'),
+          require.resolve('punycode'),
+        ],
       },
     },
 

renovate.json

@@ -4570,9 +4570,9 @@
       "enabled": true
     },
     {
-      "groupName": "node-libs-browser",
+      "groupName": "node-stdlib-browser",
       "matchDepNames": [
-        "node-libs-browser"
+        "node-stdlib-browser"
       ],
       "reviewers": [
         "team:kibana-operations"

src/platform/packages/private/kbn-node-libs-browser-webpack-plugin/BUILD.bazel

@@ -23,7 +23,7 @@ SRCS = glob(
 )
 
 BUNDLER_DEPS = [
-  "@npm//node-libs-browser",
+  "@npm//node-stdlib-browser",
 ]
 
 filegroup(

src/platform/packages/private/kbn-node-libs-browser-webpack-plugin/index.js

@@ -10,8 +10,16 @@
 /** @typedef {import('webpack').Compiler} WebpackCompiler */
 
 /* eslint-disable import/no-extraneous-dependencies */
-// @ts-expect-error
-const nodeLibsBrowser = require('node-libs-browser');
+const nodeStdlibBrowser = require('node-stdlib-browser');
+
+/**
+ * @param {string} pkgName
+ * @returns {string}
+ */
+const getStdLibBrowserPackage = (pkgName) => {
+  // @ts-expect-error
+  return require.resolve(nodeStdlibBrowser[pkgName]);
+};
 
 const NodeLibsBrowserPlugin = class NodeLibsBrowserPlugin {
   /**
@@ -20,51 +28,51 @@ const NodeLibsBrowserPlugin = class NodeLibsBrowserPlugin {
   apply(compiler) {
     compiler.options.plugins.push(
       new compiler.webpack.ProvidePlugin({
-        Buffer: [nodeLibsBrowser.buffer, 'Buffer'],
-        console: nodeLibsBrowser.console,
-        process: nodeLibsBrowser.process,
+        Buffer: [getStdLibBrowserPackage('buffer'), 'Buffer'],
+        console: getStdLibBrowserPackage('console'),
+        process: getStdLibBrowserPackage('process'),
       })
     );
 
     compiler.options.resolve.fallback = {
-      assert: nodeLibsBrowser.assert,
-      buffer: nodeLibsBrowser.buffer,
+      assert: getStdLibBrowserPackage('assert'),
+      buffer: getStdLibBrowserPackage('buffer'),
       child_process: false,
       cluster: false,
       console: false,
-      constants: nodeLibsBrowser.constants,
-      crypto: nodeLibsBrowser.crypto,
+      constants: getStdLibBrowserPackage('constants'),
+      crypto: getStdLibBrowserPackage('crypto'),
       dgram: false,
       dns: false,
-      domain: nodeLibsBrowser.domain,
-      events: nodeLibsBrowser.events,
+      domain: getStdLibBrowserPackage('domain'),
+      events: getStdLibBrowserPackage('events'),
       fs: false,
-      http: nodeLibsBrowser.http,
-      https: nodeLibsBrowser.https,
+      http: getStdLibBrowserPackage('http'),
+      https: getStdLibBrowserPackage('https'),
       module: false,
       net: false,
-      os: nodeLibsBrowser.os,
-      path: nodeLibsBrowser.path,
-      punycode: nodeLibsBrowser.punycode,
-      process: nodeLibsBrowser.process,
-      querystring: nodeLibsBrowser.querystring,
+      os: getStdLibBrowserPackage('os'),
+      path: getStdLibBrowserPackage('path'),
+      punycode: getStdLibBrowserPackage('punycode'),
+      process: getStdLibBrowserPackage('process'),
+      querystring: getStdLibBrowserPackage('querystring'),
       readline: false,
       repl: false,
-      stream: nodeLibsBrowser.stream,
-      _stream_duplex: nodeLibsBrowser._stream_duplex,
-      _stream_passthrough: nodeLibsBrowser._stream_passthrough,
-      _stream_readable: nodeLibsBrowser._stream_readable,
-      _stream_transform: nodeLibsBrowser._stream_transform,
-      _stream_writable: nodeLibsBrowser._stream_writable,
-      string_decoder: nodeLibsBrowser.string_decoder,
-      sys: nodeLibsBrowser.sys,
-      timers: nodeLibsBrowser.timers,
+      stream: getStdLibBrowserPackage('stream'),
+      _stream_duplex: getStdLibBrowserPackage('_stream_duplex'),
+      _stream_passthrough: getStdLibBrowserPackage('_stream_passthrough'),
+      _stream_readable: getStdLibBrowserPackage('_stream_readable'),
+      _stream_transform: getStdLibBrowserPackage('_stream_transform'),
+      _stream_writable: getStdLibBrowserPackage('_stream_writable'),
+      string_decoder: getStdLibBrowserPackage('string_decoder'),
+      sys: getStdLibBrowserPackage('sys'),
+      timers: getStdLibBrowserPackage('timers'),
       tls: false,
-      tty: nodeLibsBrowser.tty,
-      url: nodeLibsBrowser.url,
-      util: nodeLibsBrowser.util,
-      vm: nodeLibsBrowser.vm,
-      zlib: nodeLibsBrowser.zlib,
+      tty: getStdLibBrowserPackage('tty'),
+      url: getStdLibBrowserPackage('url'),
+      util: getStdLibBrowserPackage('util'),
+      vm: getStdLibBrowserPackage('vm'),
+      zlib: getStdLibBrowserPackage('zlib'),
       ...compiler.options.resolve.fallback,
     };
   }

src/platform/packages/private/kbn-ui-shared-deps-npm/BUILD.bazel

@@ -53,7 +53,7 @@ RUNTIME_DEPS = [
   "@npm//jquery",
   "@npm//lodash",
   "@npm//moment-timezone",
-  "@npm//node-libs-browser",
+  "@npm//node-stdlib-browser",
   "@npm//react-dom",
   "@npm//react-router-dom",
   "@npm//react-router-dom-v5-compat",

src/platform/packages/private/kbn-ui-shared-deps-npm/webpack.config.js

@@ -39,6 +39,8 @@ module.exports = (_, argv) => {
         'buffer',
         'punycode',
         'util',
+        'url',
+        'qs',
 
         /**
          * babel runtime helpers referenced from entry chunks
@@ -143,6 +145,16 @@ module.exports = (_, argv) => {
         // https://gist.github.com/bvaughn/25e6233aeb1b4f0cdb8d8366e54a3977#webpack-4
         'react-dom$': 'react-dom/profiling',
         'scheduler/tracing': 'scheduler/tracing-profiling',
+        // NOTE: We use this to make sure that buffer and punycode bundled are the ones
+        // installed from node-stdlib-browser and are in sync in between shared deps and plugins bundles
+        buffer: [
+          Path.resolve(REPO_ROOT, 'node_modules/node-stdlib-browser/node_modules/buffer'),
+          require.resolve('buffer'),
+        ],
+        punycode: [
+          Path.resolve(REPO_ROOT, 'node_modules/node-stdlib-browser/node_modules/punycode'),
+          require.resolve('punycode'),
+        ],
       },
       extensions: ['.js', '.ts'],
       mainFields: ['browser', 'module', 'main'],