Skip to content

[Obs AI Assistant] Remove double confirmation when deleting conversation#217991

Merged
eleonoramicozzi merged 5 commits into
elastic:mainfrom
eleonoramicozzi:remove-checkbox
Apr 14, 2025
Merged

[Obs AI Assistant] Remove double confirmation when deleting conversation#217991
eleonoramicozzi merged 5 commits into
elastic:mainfrom
eleonoramicozzi:remove-checkbox

Conversation

@eleonoramicozzi
Copy link
Copy Markdown
Contributor

@eleonoramicozzi eleonoramicozzi commented Apr 11, 2025 •
edited by kibanamachine
Loading

Closes #213987

Summary

Remove the checkbox from the confirm modal to avoid double confirmation.

Before

Screenshot 2025-04-11 at 11 56 54

After

Screenshot 2025-04-11 at 11 07 19

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@eleonoramicozzi eleonoramicozzi self-assigned this Apr 11, 2025
@eleonoramicozzi eleonoramicozzi requested review from a team as code owners April 11, 2025 12:54
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 11, 2025

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@viduni94 viduni94 added the backport:skip This PR does not require backporting label Apr 11, 2025
@viduni94
Copy link
Copy Markdown
Contributor

viduni94 commented Apr 11, 2025

@eleonoramicozzi I've added the backport:skip label because we are not merging this to older versions.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 14, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 251.7KB 251.2KB -529.0B
searchAssistant 166.0KB 165.5KB -519.0B
total -1.0KB

History

cc @eleonoramicozzi

@eleonoramicozzi eleonoramicozzi merged commit b8e78bc into elastic:main Apr 14, 2025
9 checks passed
@eleonoramicozzi eleonoramicozzi added backport:version Backport to applied version labels v8.19.0 and removed backport:skip This PR does not require backporting labels Jun 9, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 9, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15533596581

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 9, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15533596665

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2025
@eleonoramicozzi @kibanamachine
[Obs AI Assistant] Remove double confirmation when deleting conversat…
be90629 
…ion (elastic#217991)

Closes elastic#213987

## Summary

Remove the checkbox from the confirm modal to avoid double confirmation.

### Before

<img width="475" alt="Screenshot 2025-04-11 at 11 56 54"
src="https://github.com/user-attachments/assets/6b24aa8a-06b8-4f97-b43d-a82e91ce8328"
/>

### After

<img width="580" alt="Screenshot 2025-04-11 at 11 07 19"
src="https://github.com/user-attachments/assets/91965922-8b66-473a-903c-c6d14e2ee49e"
/>

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8e78bc)
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 9, 2025
@eleonoramicozzi @kibanamachine
[Obs AI Assistant] Remove double confirmation when deleting conversat…
955a08a 
…ion (elastic#217991)

Closes elastic#213987

## Summary

Remove the checkbox from the confirm modal to avoid double confirmation.

### Before

<img width="475" alt="Screenshot 2025-04-11 at 11 56 54"
src="https://github.com/user-attachments/assets/6b24aa8a-06b8-4f97-b43d-a82e91ce8328"
/>

### After

<img width="580" alt="Screenshot 2025-04-11 at 11 07 19"
src="https://github.com/user-attachments/assets/91965922-8b66-473a-903c-c6d14e2ee49e"
/>

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8e78bc)
@kibanamachine kibanamachine mentioned this pull request Jun 9, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 9, 2025
@kibanamachine @eleonoramicozzi
[8.19] [Obs AI Assistant] Remove double confirmation when deleting co…
6a3bd46 
…nversation (#217991) (#223100)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Obs AI Assistant] Remove double confirmation when deleting
conversation (#217991)](#217991)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"eleonoramicozzi","email":"52030607+eleonoramicozzi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-14T17:48:54Z","message":"[Obs
AI Assistant] Remove double confirmation when deleting conversation
(#217991)\n\nCloses
https://github.com/elastic/kibana/issues/213987\n\n## Summary\n\nRemove
the checkbox from the confirm modal to avoid double confirmation.\n\n###
Before\n\n<img width=\"475\" alt=\"Screenshot 2025-04-11 at 11 56
54\"\nsrc=\"https://github.com/user-attachments/assets/6b24aa8a-06b8-4f97-b43d-a82e91ce8328\"\n/>\n\n###
After\n\n<img width=\"580\" alt=\"Screenshot 2025-04-11 at 11 07
19\"\nsrc=\"https://github.com/user-attachments/assets/91965922-8b66-473a-903c-c6d14e2ee49e\"\n/>\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b8e78bcd5544d636bdb200535f5fd61aea7a68e5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Obs
AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI
Assistant] Remove double confirmation when deleting
conversation","number":217991,"url":"https://github.com/elastic/kibana/pull/217991","mergeCommit":{"message":"[Obs
AI Assistant] Remove double confirmation when deleting conversation
(#217991)\n\nCloses
https://github.com/elastic/kibana/issues/213987\n\n## Summary\n\nRemove
the checkbox from the confirm modal to avoid double confirmation.\n\n###
Before\n\n<img width=\"475\" alt=\"Screenshot 2025-04-11 at 11 56
54\"\nsrc=\"https://github.com/user-attachments/assets/6b24aa8a-06b8-4f97-b43d-a82e91ce8328\"\n/>\n\n###
After\n\n<img width=\"580\" alt=\"Screenshot 2025-04-11 at 11 07
19\"\nsrc=\"https://github.com/user-attachments/assets/91965922-8b66-473a-903c-c6d14e2ee49e\"\n/>\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b8e78bcd5544d636bdb200535f5fd61aea7a68e5"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217991","number":217991,"mergeCommit":{"message":"[Obs
AI Assistant] Remove double confirmation when deleting conversation
(#217991)\n\nCloses
https://github.com/elastic/kibana/issues/213987\n\n## Summary\n\nRemove
the checkbox from the confirm modal to avoid double confirmation.\n\n###
Before\n\n<img width=\"475\" alt=\"Screenshot 2025-04-11 at 11 56
54\"\nsrc=\"https://github.com/user-attachments/assets/6b24aa8a-06b8-4f97-b43d-a82e91ce8328\"\n/>\n\n###
After\n\n<img width=\"580\" alt=\"Screenshot 2025-04-11 at 11 07
19\"\nsrc=\"https://github.com/user-attachments/assets/91965922-8b66-473a-903c-c6d14e2ee49e\"\n/>\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b8e78bcd5544d636bdb200535f5fd61aea7a68e5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: eleonoramicozzi <52030607+eleonoramicozzi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neptunian neptunian neptunian approved these changes

Assignees

@eleonoramicozzi eleonoramicozzi

Labels

backport:version Backport to applied version labels release_note:enhancement Team:Obs AI Assistant Observability AI Assistant v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Remove double confirmation when deleting conversation

5 participants

@eleonoramicozzi @elasticmachine @viduni94 @kibanamachine @neptunian