[8.x] [Synthtrace] Fix wrong url build in the Kibana client (#217678)#217877
Merged
kibanamachine merged 3 commits intoelastic:8.19from May 28, 2025
Merged
[8.x] [Synthtrace] Fix wrong url build in the Kibana client (#217678)#217877kibanamachine merged 3 commits intoelastic:8.19from
kibanamachine merged 3 commits intoelastic:8.19from
Conversation
Relates to elastic#217529 elastic#216653 elastic#216844 ## Summary The issue was introduced in the [PR here](https://github.com/elastic/kibana/pull/212120/files#diff-34f8e7299930135fd708d98018fc6f4141d6e7c25df7e5fdb90f3472ad0e2948R36): basically, the URL will look like: ` http:/user:pass@localhost:5620/api/fleet/epm/packages/apm?prerelease=false` because `Path.join` will strip the `/` which is needed in this case - this URL is also passed to `getFetchAgent`. This PR will fix this issue. (cherry picked from commit 7f0a625)
botelastic
bot
added
the
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
I updated the target branch from When you have a moment can you double check everything is in order and proceed as usual if so? Feel free to reach out if there's any questions. |
Member
@jbudz Thank you! LGTM :) I think this should be the only backport needed so it's good to go |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation