Skip to content

[ES|QL] Adds license knowledge to the editor#217796

Merged
stratoula merged 5 commits intoelastic:mainfrom
stratoula:esql-license-knowledge
Apr 14, 2025
Merged

[ES|QL] Adds license knowledge to the editor#217796
stratoula merged 5 commits intoelastic:mainfrom
stratoula:esql-license-knowledge

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 10, 2025

Summary

Part of #216791

  • Suggests remote indices if ES license plugin enables it
image
  • Doesn't suggest remote indices for basic license
image

Checklist

@stratoula stratoula added v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Apr 10, 2025
@stratoula stratoula marked this pull request as ready for review April 10, 2025 12:10
@stratoula stratoula requested review from a team as code owners April 10, 2025 12:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 14, 2025

💔 Build Failed

Failed CI Steps

History

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula enabled auto-merge (squash) April 14, 2025 09:46
@stratoula stratoula merged commit 708917d into elastic:main Apr 14, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14443832906

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 217796

Questions ?

Please refer to the Backport tool documentation

umbopepato pushed a commit to umbopepato/kibana that referenced this pull request Apr 14, 2025
## Summary

Part of elastic#216791

- Suggests remote indices if ES license plugin enables it 

<img width="580" alt="image"
src="https://github.com/user-attachments/assets/a237f646-286e-489c-b41b-a1ce7d82440a"
/>



- Doesn't suggest remote indices for basic license
<img width="292" alt="image"
src="https://github.com/user-attachments/assets/2bc9e512-91ab-4b20-94ce-d1931732567e"
/>


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@stratoula
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Apr 14, 2025
## Summary

Part of elastic#216791

- Suggests remote indices if ES license plugin enables it

<img width="580" alt="image"
src="https://github.com/user-attachments/assets/a237f646-286e-489c-b41b-a1ce7d82440a"
/>

- Doesn't suggest remote indices for basic license
<img width="292" alt="image"
src="https://github.com/user-attachments/assets/2bc9e512-91ab-4b20-94ce-d1931732567e"
/>

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 708917d)

# Conflicts:
#	src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx
stratoula added a commit that referenced this pull request Apr 15, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Adds license knowledge to the editor
(#217796)](#217796)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-04-14T10:52:10Z","message":"[ES|QL]
Adds license knowledge to the editor (#217796)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana/issues/216791\n\n- Suggests remote
indices if ES license plugin enables it \n\n<img width=\"580\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a237f646-286e-489c-b41b-a1ce7d82440a\"\n/>\n\n\n\n-
Doesn't suggest remote indices for basic license\n<img width=\"292\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2bc9e512-91ab-4b20-94ce-d1931732567e\"\n/>\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"708917df6ea4c60b666d2ed11cb0b3865034b342","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Adds license knowledge to the
editor","number":217796,"url":"https://github.com/elastic/kibana/pull/217796","mergeCommit":{"message":"[ES|QL]
Adds license knowledge to the editor (#217796)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana/issues/216791\n\n- Suggests remote
indices if ES license plugin enables it \n\n<img width=\"580\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a237f646-286e-489c-b41b-a1ce7d82440a\"\n/>\n\n\n\n-
Doesn't suggest remote indices for basic license\n<img width=\"292\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2bc9e512-91ab-4b20-94ce-d1931732567e\"\n/>\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"708917df6ea4c60b666d2ed11cb0b3865034b342"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217796","number":217796,"mergeCommit":{"message":"[ES|QL]
Adds license knowledge to the editor (#217796)\n\n## Summary\n\nPart of
https://github.com/elastic/kibana/issues/216791\n\n- Suggests remote
indices if ES license plugin enables it \n\n<img width=\"580\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/a237f646-286e-489c-b41b-a1ce7d82440a\"\n/>\n\n\n\n-
Doesn't suggest remote indices for basic license\n<img width=\"292\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2bc9e512-91ab-4b20-94ce-d1931732567e\"\n/>\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"708917df6ea4c60b666d2ed11cb0b3865034b342"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants