Skip to content

[8.x] [A11y][APM] Improve aria-label for EuiCodeBlock on onboarding page (#217292)#217690

Merged
rmyz merged 2 commits intoelastic:8.xfrom
rmyz:backport/8.x/pr-217292
Apr 10, 2025
Merged

[8.x] [A11y][APM] Improve aria-label for EuiCodeBlock on onboarding page (#217292)#217690
rmyz merged 2 commits intoelastic:8.xfrom
rmyz:backport/8.x/pr-217292

Conversation

@rmyz
Copy link
Contributor

@rmyz rmyz commented Apr 9, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

elastic#217292)

## Summary

Fixes elastic#195030

This PR adds `aria-label` with language context for `EuiCodeBlock` in
the APM onboarding page.

(cherry picked from commit a49dc03)

# Conflicts:
#	x-pack/solutions/observability/plugins/apm/public/components/app/onboarding/instructions_set.tsx
@rmyz rmyz requested a review from kibanamachine as a code owner April 9, 2025 14:09
@rmyz rmyz added the backport This PR is a backport of another PR label Apr 9, 2025
@rmyz rmyz enabled auto-merge (squash) April 9, 2025 14:09
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Apr 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rmyz rmyz merged commit 095c1ae into elastic:8.x Apr 10, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +1.9KB

History

@rmyz rmyz deleted the backport/8.x/pr-217292 branch April 10, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants