[8.x] [ObsUx][A11y] Add unique accessible lables to metadata table (#217496)#217657
Merged
MiriamAparicio merged 1 commit intoelastic:8.xfrom Apr 9, 2025
Merged
Conversation
…#217496) Closes elastic#194972 ## Summary Add unique accessible labels to metadata table ### How to test Use a screen reader to navigate the table On Host details, Metadata tab 1. Verify the first column in the table header announces Pin Fields column <img width="1262" alt="Screenshot 2025-04-08 at 12 38 28" src="https://github.com/user-attachments/assets/bdac5799-97d4-4001-b5f0-f9230227b749" /> 2. Verify the Pin column row announces which field pins <img width="1262" alt="Screenshot 2025-04-08 at 12 38 45" src="https://github.com/user-attachments/assets/a9a18fc4-4f46-49d7-880e-9b77eca476dd" /> <img width="1262" alt="Screenshot 2025-04-08 at 12 39 14" src="https://github.com/user-attachments/assets/889ca03f-aa00-4360-87b5-6d767fe11cff" /> 3. Verify the "+ x more" does announce more of which field <img width="1262" alt="Screenshot 2025-04-08 at 12 39 35" src="https://github.com/user-attachments/assets/dfba3fd9-7e71-4ef6-956e-3761094f4667" /> (cherry picked from commit 92a9f85) # Conflicts: # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json
jennypavlova
approved these changes
Apr 9, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
|
MiriamAparicio
added a commit
that referenced
this pull request
Apr 10, 2025
…217496) (#217813) # Backport This will backport the following commits from `main` to `8.18`: - [[ObsUx][A11y] Add unique accessible lables to metadata table (#217496)](#217496) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"31922082+MiriamAparicio@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-09T07:41:30Z","message":"[ObsUx][A11y] Add unique accessible lables to metadata table (#217496)\n\nCloses https://github.com/elastic/kibana/issues/194972\n\n## Summary\n\nAdd unique accessible labels to metadata table\n\n### How to test\n\nUse a screen reader to navigate the table\n\nOn Host details, Metadata tab\n\n1. Verify the first column in the table header announces Pin Fields\ncolumn\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 38 28\"\nsrc=\"https://github.com/user-attachments/assets/bdac5799-97d4-4001-b5f0-f9230227b749\"\n/>\n\n2. Verify the Pin column row announces which field pins\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 38 45\"\nsrc=\"https://github.com/user-attachments/assets/a9a18fc4-4f46-49d7-880e-9b77eca476dd\"\n/>\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 39 14\"\nsrc=\"https://github.com/user-attachments/assets/889ca03f-aa00-4360-87b5-6d767fe11cff\"\n/>\n\n3. Verify the \"+ x more\" does announce more of which field\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 39 35\"\nsrc=\"https://github.com/user-attachments/assets/dfba3fd9-7e71-4ef6-956e-3761094f4667\"\n/>","sha":"92a9f8531afa6bb93719db65f4637607c9435beb","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ObsUx][A11y] Add unique accessible lables to metadata table","number":217496,"url":"https://github.com/elastic/kibana/pull/217496","mergeCommit":{"message":"[ObsUx][A11y] Add unique accessible lables to metadata table (#217496)\n\nCloses https://github.com/elastic/kibana/issues/194972\n\n## Summary\n\nAdd unique accessible labels to metadata table\n\n### How to test\n\nUse a screen reader to navigate the table\n\nOn Host details, Metadata tab\n\n1. Verify the first column in the table header announces Pin Fields\ncolumn\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 38 28\"\nsrc=\"https://github.com/user-attachments/assets/bdac5799-97d4-4001-b5f0-f9230227b749\"\n/>\n\n2. Verify the Pin column row announces which field pins\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 38 45\"\nsrc=\"https://github.com/user-attachments/assets/a9a18fc4-4f46-49d7-880e-9b77eca476dd\"\n/>\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 39 14\"\nsrc=\"https://github.com/user-attachments/assets/889ca03f-aa00-4360-87b5-6d767fe11cff\"\n/>\n\n3. Verify the \"+ x more\" does announce more of which field\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 39 35\"\nsrc=\"https://github.com/user-attachments/assets/dfba3fd9-7e71-4ef6-956e-3761094f4667\"\n/>","sha":"92a9f8531afa6bb93719db65f4637607c9435beb"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217621","number":217621,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217496","number":217496,"mergeCommit":{"message":"[ObsUx][A11y] Add unique accessible lables to metadata table (#217496)\n\nCloses https://github.com/elastic/kibana/issues/194972\n\n## Summary\n\nAdd unique accessible labels to metadata table\n\n### How to test\n\nUse a screen reader to navigate the table\n\nOn Host details, Metadata tab\n\n1. Verify the first column in the table header announces Pin Fields\ncolumn\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 38 28\"\nsrc=\"https://github.com/user-attachments/assets/bdac5799-97d4-4001-b5f0-f9230227b749\"\n/>\n\n2. Verify the Pin column row announces which field pins\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 38 45\"\nsrc=\"https://github.com/user-attachments/assets/a9a18fc4-4f46-49d7-880e-9b77eca476dd\"\n/>\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 39 14\"\nsrc=\"https://github.com/user-attachments/assets/889ca03f-aa00-4360-87b5-6d767fe11cff\"\n/>\n\n3. Verify the \"+ x more\" does announce more of which field\n\n<img width=\"1262\" alt=\"Screenshot 2025-04-08 at 12 39 35\"\nsrc=\"https://github.com/user-attachments/assets/dfba3fd9-7e71-4ef6-956e-3761094f4667\"\n/>","sha":"92a9f8531afa6bb93719db65f4637607c9435beb"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217657","number":217657,"state":"MERGED","mergeCommit":{"sha":"3b5e43ab47a19264d60771b161202ac677060a3b","message":"[8.x] [ObsUx][A11y] Add unique accessible lables to metadata table (#217496) (#217657)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[ObsUx][A11y] Add unique accessible lables to metadata table\n(#217496)](https://github.com/elastic/kibana/pull/217496)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation