Skip to content

[8.18] [A11y][APM] Add missing aria-label for some services buttons (#217325) #217613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 2 commits into from
Apr 9, 2025
Merged

[8.18] [A11y][APM] Add missing aria-label for some services buttons (#217325) #217613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb5a541
[A11y][APM] Add missing `aria-label` for some services buttons (#217325)
rmyz Apr 9, 2025
f0a9ee4
Merge branch '8.18' into backport/8.18/pr-217325
rmyz Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...servability/plugins/apm/public/components/app/service_groups/service_groups_list/sort.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ export function Sort({ type, onChange }: Props) {
return (
<EuiSelect
data-test-subj="apmSortSelect"
aria-label={i18n.translate('xpack.apm.serviceGroups.list.sort.ariaLabel', {
defaultMessage: 'Sort service groups by',
})}
options={options}
value={type}
onChange={(e) => onChange(e.target.value as ServiceGroupsSortType)}
Expand Down
27 changes: 23 additions & 4 deletions ...utions/observability/plugins/apm/public/components/shared/key_value_filter_list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { i18n } from '@kbn/i18n';
import React, { Fragment } from 'react';
import styled from 'styled-components';
import { isEmpty } from 'lodash';
import { css } from '@emotion/react';

interface KeyValue {
key: string;
Expand Down Expand Up @@ -78,23 +79,41 @@ export function KeyValueFilterList({
<Fragment key={key}>
<EuiDescriptionListTitle
className="descriptionList__title"
style={{ height: '40px' }}
css={css`
height: 40px;
`}
>
<EuiText size="s" style={{ fontWeight: 'bold' }}>
<EuiText
size="s"
css={css`
font-weight: bold;
`}
>
{key}
</EuiText>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription
className="descriptionList__description"
style={{ height: '40px' }}
css={css`
height: 40px;
`}
>
<EuiFlexGroup alignItems="baseline" responsive={false} gutterSize="none">
<EuiFlexItem style={{ minWidth: '32px' }} grow={false}>
<EuiFlexItem
css={css`
min-width: 32px;
`}
grow={false}
>
{isFilterable && (
<EuiButtonEmpty
onClick={() => {
onClickFilter({ key, value });
}}
aria-label={i18n.translate(
'xpack.apm.keyValueFilterList.actionFilterLabel',
{ defaultMessage: 'Filter by value' }
)}
data-test-subj={`filter_by_${key}`}
>
<EuiToolTip
Expand Down