Skip to content

[8.x] [Dashboard] Inject / extract tag references (#214788) #217590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickpeihl merged 2 commits into from
Apr 9, 2025
Merged

[8.x] [Dashboard] Inject / extract tag references (#214788) #217590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d7ba90
[Dashboard] Inject / extract tag references (#214788)
nickpeihl Mar 31, 2025
4cf82b0
Merge remote-tracking branch 'upstream/8.x' into backport/8.x/pr-214788
nickpeihl Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions oas_docs/bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6293,6 +6293,13 @@
"description": "A short description.",
"type": "string"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeRestore": {
"default": false,
"description": "Whether to restore time upon viewing this dashboard",
Expand Down Expand Up @@ -6939,6 +6946,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -7593,6 +7607,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8131,6 +8152,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8757,6 +8785,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -9289,6 +9324,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down
42 changes: 42 additions & 0 deletions oas_docs/bundle.serverless.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5830,6 +5830,13 @@
"description": "A short description.",
"type": "string"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeRestore": {
"default": false,
"description": "Whether to restore time upon viewing this dashboard",
Expand Down Expand Up @@ -6476,6 +6483,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -7130,6 +7144,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -7668,6 +7689,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8294,6 +8322,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down Expand Up @@ -8826,6 +8861,13 @@
],
"type": "object"
},
"tags": {
"items": {
"description": "An array of tags applied to this dashboard",
"type": "string"
},
"type": "array"
},
"timeFrom": {
"description": "An ISO string indicating when to restore time from",
"type": "string"
Expand Down
30 changes: 30 additions & 0 deletions oas_docs/output/kibana.serverless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5540,6 +5540,11 @@ paths:
default: ''
description: A short description.
type: string
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeRestore:
default: false
description: Whether to restore time upon viewing this dashboard
Expand Down Expand Up @@ -6000,6 +6005,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -6465,6 +6475,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -6853,6 +6868,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -7298,6 +7318,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -7682,6 +7707,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down
30 changes: 30 additions & 0 deletions oas_docs/output/kibana.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8056,6 +8056,11 @@ paths:
default: ''
description: A short description.
type: string
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeRestore:
default: false
description: Whether to restore time upon viewing this dashboard
Expand Down Expand Up @@ -8516,6 +8521,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -8981,6 +8991,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -9369,6 +9384,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -9814,6 +9834,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down Expand Up @@ -10198,6 +10223,11 @@ paths:
required:
- pause
- value
tags:
items:
description: An array of tags applied to this dashboard
type: string
type: array
timeFrom:
description: An ISO string indicating when to restore time from
type: string
Expand Down
2 changes: 2 additions & 0 deletions src/platform/plugins/shared/dashboard/public/dashboard_api/get_serialized_state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ export const getSerializedState = ({
{ embeddablePersistableStateService: embeddableService }
);

// TODO Provide tags as an array of tag names in the attribute. In that case, tag references
// will be extracted by the server.
const savedObjectsTaggingApi = savedObjectsTaggingService?.getTaggingApi();
const references = savedObjectsTaggingApi?.ui.updateTagsReferences
? savedObjectsTaggingApi?.ui.updateTagsReferences(dashboardReferences, tags)
Expand Down
Loading