[Charts] Use chartTheme hook everywhere#217370
Merged
markov00 merged 15 commits intoelastic:mainfrom Apr 14, 2025
Merged
Conversation
…urce-definitions/scripts/fix-location-collection.ts'
nickofthyme
approved these changes
Apr 8, 2025
...rm/plugins/shared/ml/public/application/memory_usage/nodes_overview/memory_preview_chart.tsx
Show resolved
Hide resolved
markov00
added
Team:Visualizations
…urce-definitions/scripts/fix-location-collection.ts'
markov00
added
backport:all-open
walterra
reviewed
Apr 8, 2025
.../private/data_visualizer/public/application/data_drift/charts/overlap_distribution_chart.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Apr 9, 2025
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
Desk tested, LGTM for the @elastic/security-threat-hunting-investigations team!
semd
approved these changes
Apr 10, 2025
peteharverson
approved these changes
Apr 10, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
ML changes LGTM (following Walter's testing!)
flash1293
approved these changes
Apr 10, 2025
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Streams and data set quality changes LGTM, tested in light and dark mode
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
TattdCodeMonkey
approved these changes
Apr 11, 2025
justinkambic
approved these changes
Apr 11, 2025
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Management changes LGTM
...k/solutions/observability/plugins/observability/public/components/alert_status_indicator.tsx
Show resolved
Hide resolved
nickofthyme
approved these changes
Apr 14, 2025
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14450411368 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Apr 14, 2025
## Summary This PR fixes the existing usage of the chart themes by using the provided `useElasticChartsTheme` hook that is color mode aware and theme adaptive (borealis/amsterdam) Some charts where using just the Light theme version or the legacy (aka amsterdam theme), and I've applied the hook to pick up the correct theme. TO REVIEWERS: Please pull down the PR and check if the actual changed charts looks correct with the new theme configuration. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit a9c9354) # Conflicts: # src/platform/plugins/shared/chart_expressions/expression_tagcloud/public/components/tagcloud_component.tsx # src/platform/plugins/shared/chart_expressions/expression_tagcloud/tsconfig.json # x-pack/platform/plugins/private/data_visualizer/public/application/common/components/stats_table/components/field_data_expanded_row/boolean_content.tsx # x-pack/platform/plugins/private/data_visualizer/public/application/file_data_visualizer/components/doc_count_chart/event_rate_chart.tsx # x-pack/platform/plugins/shared/triggers_actions_ui/public/application/sections/common/components/execution_duration_chart.tsx # x-pack/solutions/observability/plugins/profiling/tsconfig.json # x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/monitors_page/overview/overview/metric_item/metric_item.tsx # x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/step_details_page/step_timing_breakdown/network_timings_donut.tsx # x-pack/solutions/search/plugins/enterprise_search/tsconfig.json
markov00
added a commit
that referenced
this pull request
Apr 15, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Charts] Use chartTheme hook everywhere (#217370)](#217370) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-04-14T16:09:15Z","message":"[Charts] Use chartTheme hook everywhere (#217370)\n\n## Summary\n\nThis PR fixes the existing usage of the chart themes by using the\nprovided `useElasticChartsTheme` hook that is color mode aware and theme\nadaptive (borealis/amsterdam)\n\nSome charts where using just the Light theme version or the legacy (aka\namsterdam theme), and I've applied the hook to pick up the correct\ntheme.\n\nTO REVIEWERS: Please pull down the PR and check if the actual changed\ncharts looks correct with the new theme configuration.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"a9c9354382d0e52d7790fecf653f4c7758e3703b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ElasticCharts","Team:Visualizations","release_note:skip","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Charts] Use chartTheme hook everywhere","number":217370,"url":"https://github.com/elastic/kibana/pull/217370","mergeCommit":{"message":"[Charts] Use chartTheme hook everywhere (#217370)\n\n## Summary\n\nThis PR fixes the existing usage of the chart themes by using the\nprovided `useElasticChartsTheme` hook that is color mode aware and theme\nadaptive (borealis/amsterdam)\n\nSome charts where using just the Light theme version or the legacy (aka\namsterdam theme), and I've applied the hook to pick up the correct\ntheme.\n\nTO REVIEWERS: Please pull down the PR and check if the actual changed\ncharts looks correct with the new theme configuration.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"a9c9354382d0e52d7790fecf653f4c7758e3703b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217370","number":217370,"mergeCommit":{"message":"[Charts] Use chartTheme hook everywhere (#217370)\n\n## Summary\n\nThis PR fixes the existing usage of the chart themes by using the\nprovided `useElasticChartsTheme` hook that is color mode aware and theme\nadaptive (borealis/amsterdam)\n\nSome charts where using just the Light theme version or the legacy (aka\namsterdam theme), and I've applied the hook to pick up the correct\ntheme.\n\nTO REVIEWERS: Please pull down the PR and check if the actual changed\ncharts looks correct with the new theme configuration.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"a9c9354382d0e52d7790fecf653f4c7758e3703b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2 tasks
Contributor
|
@markov00 I removed the |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Jun 13, 2025
## Summary This PR fixes the existing usage of the chart themes by using the provided `useElasticChartsTheme` hook that is color mode aware and theme adaptive (borealis/amsterdam) Some charts where using just the Light theme version or the legacy (aka amsterdam theme), and I've applied the hook to pick up the correct theme. TO REVIEWERS: Please pull down the PR and check if the actual changed charts looks correct with the new theme configuration. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit a9c9354) # Conflicts: # x-pack/platform/plugins/private/data_visualizer/public/application/common/components/stats_table/components/field_data_row/column_chart.tsx # x-pack/platform/plugins/private/data_visualizer/public/application/common/components/stats_table/components/metric_distribution_chart/metric_distribution_chart.tsx # x-pack/platform/plugins/shared/dataset_quality/tsconfig.json # x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_lifecycle/ingestion_rate.tsx # x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/documents_column.tsx # x-pack/solutions/observability/plugins/profiling/tsconfig.json # x-pack/solutions/observability/plugins/streams_app/public/components/esql_chart/controlled_esql_chart.tsx # x-pack/solutions/observability/plugins/streams_app/tsconfig.json # x-pack/solutions/security/plugins/security_solution/public/common/components/charts/common.test.tsx # x-pack/solutions/security/plugins/threat_intelligence/tsconfig.json
markov00
added a commit
that referenced
this pull request
Jun 13, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Charts] Use chartTheme hook everywhere (#217370)](#217370) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-04-14T16:09:15Z","message":"[Charts] Use chartTheme hook everywhere (#217370)\n\n## Summary\n\nThis PR fixes the existing usage of the chart themes by using the\nprovided `useElasticChartsTheme` hook that is color mode aware and theme\nadaptive (borealis/amsterdam)\n\nSome charts where using just the Light theme version or the legacy (aka\namsterdam theme), and I've applied the hook to pick up the correct\ntheme.\n\nTO REVIEWERS: Please pull down the PR and check if the actual changed\ncharts looks correct with the new theme configuration.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"a9c9354382d0e52d7790fecf653f4c7758e3703b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ElasticCharts","Team:Visualizations","release_note:skip","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Charts] Use chartTheme hook everywhere","number":217370,"url":"https://github.com/elastic/kibana/pull/217370","mergeCommit":{"message":"[Charts] Use chartTheme hook everywhere (#217370)\n\n## Summary\n\nThis PR fixes the existing usage of the chart themes by using the\nprovided `useElasticChartsTheme` hook that is color mode aware and theme\nadaptive (borealis/amsterdam)\n\nSome charts where using just the Light theme version or the legacy (aka\namsterdam theme), and I've applied the hook to pick up the correct\ntheme.\n\nTO REVIEWERS: Please pull down the PR and check if the actual changed\ncharts looks correct with the new theme configuration.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"a9c9354382d0e52d7790fecf653f4c7758e3703b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217370","number":217370,"mergeCommit":{"message":"[Charts] Use chartTheme hook everywhere (#217370)\n\n## Summary\n\nThis PR fixes the existing usage of the chart themes by using the\nprovided `useElasticChartsTheme` hook that is color mode aware and theme\nadaptive (borealis/amsterdam)\n\nSome charts where using just the Light theme version or the legacy (aka\namsterdam theme), and I've applied the hook to pick up the correct\ntheme.\n\nTO REVIEWERS: Please pull down the PR and check if the actual changed\ncharts looks correct with the new theme configuration.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"a9c9354382d0e52d7790fecf653f4c7758e3703b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218147","number":218147,"state":"MERGED","mergeCommit":{"sha":"13af80f2d4aaf30a0a1ffa76fbc24cf2d0d995a0","message":"[8.x] [Charts] Use chartTheme hook everywhere (#217370) (#218147)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Charts] Use chartTheme hook everywhere\n(#217370)](https://github.com/elastic/kibana/pull/217370)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the existing usage of the chart themes by using the provided
useElasticChartsThemehook that is color mode aware and theme adaptive (borealis/amsterdam)Some charts where using just the Light theme version or the legacy (aka amsterdam theme), and I've applied the hook to pick up the correct theme.
TO REVIEWERS: Please pull down the PR and check if the actual changed charts looks correct with the new theme configuration.