[9.0] [Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file (#216978)#217334
Merged
kibanamachine merged 1 commit intoelastic:9.0from Apr 7, 2025
Conversation
…idental config backup file (elastic#216978) Closes elastic#199744 * Adds a separate `sed` commands for Linux and macOS when replacing API key within the Agent config. GNU and BSD versions of `sed` treat `-i` (in-place editing) argument differently, GNU version allows `-i` without a value while BSD version requires a backup file extension even when it's empty 🫠 * Adds filtering of unsupported input types inside the integration policies. For now it only filters out `httpjson`. ## How to test 1. Go through the auto-detect flow 2. Make sure there is no `'elastic-agent.yml='` file in the Agent directory, or any other weird artifacts 3. Inspect individual integration config files, make sure they don't have `httpjson` inputs Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> (cherry picked from commit ec72d4a)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]
|
mykolaharmash
added a commit
that referenced
this pull request
Apr 9, 2025
…fix accidental config backup file (#216978) (#217497) # Backport This will backport the following commits from `main` to `8.18`: - [[Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file (#216978)](#216978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2025-04-07T13:57:33Z","message":"[Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file (#216978)\n\nCloses https://github.com/elastic/kibana/issues/199744\n\n* Adds a separate `sed` commands for Linux and macOS when replacing API\nkey within the Agent config. GNU and BSD versions of `sed` treat `-i`\n(in-place editing) argument differently, GNU version allows `-i` without\na value while BSD version requires a backup file extension even when\nit's empty 🫠\n* Adds filtering of unsupported input types inside the integration\npolicies. For now it only filters out `httpjson`.\n\n## How to test\n1. Go through the auto-detect flow\n2. Make sure there is no `'elastic-agent.yml='` file in the Agent\ndirectory, or any other weird artifacts\n3. Inspect individual integration config files, make sure they don't\nhave `httpjson` inputs\n\nCo-authored-by: Joe Reuter <johannes.reuter@elastic.co>","sha":"ec72d4a880cc7c396fc0376bb33bdb2821bc6db5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Feature: Observability Onboarding","backport:version","v9.1.0","v8.18.1","v9.0.1"],"title":"[Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file","number":216978,"url":"https://github.com/elastic/kibana/pull/216978","mergeCommit":{"message":"[Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file (#216978)\n\nCloses https://github.com/elastic/kibana/issues/199744\n\n* Adds a separate `sed` commands for Linux and macOS when replacing API\nkey within the Agent config. GNU and BSD versions of `sed` treat `-i`\n(in-place editing) argument differently, GNU version allows `-i` without\na value while BSD version requires a backup file extension even when\nit's empty 🫠\n* Adds filtering of unsupported input types inside the integration\npolicies. For now it only filters out `httpjson`.\n\n## How to test\n1. Go through the auto-detect flow\n2. Make sure there is no `'elastic-agent.yml='` file in the Agent\ndirectory, or any other weird artifacts\n3. Inspect individual integration config files, make sure they don't\nhave `httpjson` inputs\n\nCo-authored-by: Joe Reuter <johannes.reuter@elastic.co>","sha":"ec72d4a880cc7c396fc0376bb33bdb2821bc6db5"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217334","number":217334,"state":"MERGED","mergeCommit":{"sha":"5ea5a88198dc9bf1a5d235764596ab3914b328e1","message":"[9.0] [Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file (#216978) (#217334)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix\naccidental config backup file\n(#216978)](https://github.com/elastic/kibana/pull/216978)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Mykola Harmash <mykola.harmash@gmail.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216978","number":216978,"mergeCommit":{"message":"[Oblt Onboarding][Auto Detect] Filter out httpjson inputs and fix accidental config backup file (#216978)\n\nCloses https://github.com/elastic/kibana/issues/199744\n\n* Adds a separate `sed` commands for Linux and macOS when replacing API\nkey within the Agent config. GNU and BSD versions of `sed` treat `-i`\n(in-place editing) argument differently, GNU version allows `-i` without\na value while BSD version requires a backup file extension even when\nit's empty 🫠\n* Adds filtering of unsupported input types inside the integration\npolicies. For now it only filters out `httpjson`.\n\n## How to test\n1. Go through the auto-detect flow\n2. Make sure there is no `'elastic-agent.yml='` file in the Agent\ndirectory, or any other weird artifacts\n3. Inspect individual integration config files, make sure they don't\nhave `httpjson` inputs\n\nCo-authored-by: Joe Reuter <johannes.reuter@elastic.co>","sha":"ec72d4a880cc7c396fc0376bb33bdb2821bc6db5"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation