[8.17] [ML] AIOps: Change Point Detection in Dashboards embeddable fix (#217178)#217315
Merged
Conversation
…tic#217178) It fixes an issue where adding the `Change Point Detection` embeddable didn't work properly. The bug was introduced in elastic#197943 The main cause was the use of `<ChangePointDetectionContextProvider>` which calls `timefilter.getActiveBounds()`. However, for `getActiveBounds` to work, `this.isTimeRangeSelectorEnabled()` must return true. By default, this is not the case within dashboards. However, we do not actually need the `ChangePointDetectionContext` inside the embeddable, so this PR removes its usage. A functional test has been added to cover adding the Change Point embeddable from the dashboards app. It's a very simple test that does not verify the embeddable's functionality, but it could be improved in a follow-up.  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d359881) # Conflicts: # x-pack/plugins/aiops/public/embeddables/change_point_chart/change_point_chart_initializer.tsx # x-pack/test/tsconfig.json
darnautov
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation