Skip to content

chore(slo): optimize resources management#217268

Merged
kdelemme merged 3 commits into
elastic:mainfrom
kdelemme:chore/simplify-resources-management
Apr 7, 2025
Merged

chore(slo): optimize resources management#217268
kdelemme merged 3 commits into
elastic:mainfrom
kdelemme:chore/simplify-resources-management

Conversation

@kdelemme
Copy link
Copy Markdown
Contributor

@kdelemme kdelemme commented Apr 5, 2025

Summary

Related to #209925

Looking at the delete SLO service, i've noticed some unecessary calls that we can safely remove:

  • uninstalling a transform will force stop it, meaning it does not need to be stopped before.
  • deletePipeline can take a wildcard in its id, so we can delete both the summary and sli pipeline in one call.

@kdelemme kdelemme marked this pull request as ready for review April 7, 2025 13:09
@kdelemme kdelemme requested a review from a team as a code owner April 7, 2025 13:09
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.1.0 labels Apr 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme kdelemme added the backport:skip This PR does not require backporting label Apr 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / should filter the table correctly

Metrics [docs]

✅ unchanged

@kdelemme kdelemme merged commit fcae30a into elastic:main Apr 7, 2025
baileycash-elastic pushed a commit to baileycash-elastic/kibana that referenced this pull request Apr 7, 2025
kdelemme added a commit to kdelemme/kibana that referenced this pull request Apr 10, 2025
@kdelemme
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kdelemme added a commit that referenced this pull request Apr 10, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(slo): optimize resources management
(#217268)](#217268)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T15:22:54Z","message":"chore(slo):
optimize resources management
(#217268)","sha":"fcae30a80961ea11de52270c56baf7a9f76eb336","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:obs-ux-management","v9.1.0","v8.19.0"],"title":"chore(slo):
optimize resources
management","number":217268,"url":"https://github.com/elastic/kibana/pull/217268","mergeCommit":{"message":"chore(slo):
optimize resources management
(#217268)","sha":"fcae30a80961ea11de52270c56baf7a9f76eb336"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217268","number":217268,"mergeCommit":{"message":"chore(slo):
optimize resources management
(#217268)","sha":"fcae30a80961ea11de52270c56baf7a9f76eb336"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants