[8.x] [Security Solution] Use static declaration for navigation hierarchy (#215969)#217248
Merged
tsullivan merged 4 commits intoelastic:8.xfrom Apr 8, 2025
Merged
[8.x] [Security Solution] Use static declaration for navigation hierarchy (#215969)#217248tsullivan merged 4 commits intoelastic:8.xfrom
tsullivan merged 4 commits intoelastic:8.xfrom
Conversation
…lastic#215969) ## Summary Part of Epic: elastic/kibana-team#1439 Addresses elastic#212903, but does not remove the landing page access. The landing page access will be removed in elastic#210893 **Changes** 1. Converts the declaration of the Security Solution side navigation for serverless and stateful projects into a static declaration, rather than algorithmically parsing registered links to dynamically build the declaration. 2. Updates the contents of the "Assets" panel to prepare for removal of that landing page. 3. Eliminates the top-level nesting of the nav items, which removes the extra space between the project title and the first nav items. See elastic@45454bd **Known issue**: Clicking the "Browse integrations" button does not close the secondary nav panel. Doing that will be a relatively simple chore, but will require some changes in the SharedUX chrome-navigation package, as well as the `LinkButton` component in the Security Solution navigation-links package. ### Screenshots Serverless  Stateful/ECH  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ef907a3) # Conflicts: # x-pack/solutions/security/plugins/security_solution_serverless/public/navigation/ai_soc/ai_soc_navigation.ts # x-pack/solutions/security/plugins/security_solution_serverless/public/navigation/side_navigation.ts # x-pack/test/security_solution_cypress/cypress/e2e/explore/navigation/navigation.cy.ts # x-pack/test/security_solution_cypress/cypress/screens/serverless_security_header.ts
2 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
|
kowalczyk-krzysztof
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation