[ES 9.0] Remove body workaround (@elastic/response-ops)

[afharo]

Summary

Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584.

We should be able to remove all usages of // @ts-expect-error elasticsearch@9.0.0 https://github.com/elastic/elasticsearch-js/issues/2584.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[afharo]

@JoshMock, @pquentin, this is an interesting one:
According to the docs, only the sort querystring parameter is allowed (and the format is a comma-separated list of fields).
However, this query has always sent sort in the body (with an object format).

[JoshMock]

I know there are some APIs that are permissive about putting some query parameters in the body instead, but the spec may be more strict, intentionally or not. @pquentin I know this has come up a couple times recently in the spec; do we have a preference on how the spec handles things that can go in query or body?

[pquentin]

The spec should reflect reality: if both are accepted it means that Elasticsearch has specific code for both, and we should encode it in the spec.

Then it's up to the clients to choose which one to use, usually the body form.

Also, note that in 9.x the documentation for endpoints is generated from the spec, which will avoid those discrepancies.

[ymao1]

Is this saying we're formatting the sort wrong or this function is expecting the sort in the body field?

[afharo]

I'll let @JoshMock and @pquentin confirm.
But based on the documentation, body sort is not supported by ES. Although the fact that ES doesn't 400 these requests makes me think that's a "hidden feature".

[ymao1]

LGTM. Verified alerts and event log indices are installed and reinstalled successfully for both serverless and server-ful across restarts. Verified task manager update by queries continue to claim tasks as expected.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: a2880a7

Metrics [docs]

✅ unchanged

History

• 💚 Build #291414 succeeded f1729ff
• 💚 Build #290895 succeeded 2fd0409
• 💛 Build #290677 was flaky 9bc80b5
• 💔 Build #290366 failed 51b5a7e

cc @afharo