Skip to content

[Fleet] Implement show policies action#217188

Merged
nchaulet merged 5 commits into
elastic:mainfrom
nchaulet:feature-installed-integrations-policies
Apr 7, 2025
Merged

[Fleet] Implement show policies action#217188
nchaulet merged 5 commits into
elastic:mainfrom
nchaulet:feature-installed-integrations-policies

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Apr 4, 2025

Summary

Resolve #216909

Implement View policies actions in new tabular installed integrations.

When clicking view policies it opens a resizable panel containing the package details policies page.

How to test

The change is behind the installedIntegrationsTabularUI feature flag

UI Changes

Screenshot 2025-04-04 at 9 05 05 AM Screenshot 2025-04-04 at 9 05 21 AM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 4, 2025
@nchaulet nchaulet self-assigned this Apr 4, 2025
return -x;
};

export const ResizablePanelComponent: React.FunctionComponent<{
Copy link
Copy Markdown
Member Author

@nchaulet nchaulet Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heavily inspired from https://eui.elastic.co/#/layout/resizable-container#custom-resize-logic,

I tried two approach:

  • this one a behaviour that looks like a flyout with an absolution position.
  • splitting the screen in two with a resizable container, this was harder to manage, as we needed to get fixed height for the container.

@nchaulet nchaulet marked this pull request as ready for review April 4, 2025 14:27
@nchaulet nchaulet requested a review from a team as a code owner April 4, 2025 14:28
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Apr 4, 2025

@elasticmachine merge upstream

@juliaElastic
Copy link
Copy Markdown
Contributor

Looks great!

I think we should limit the height of the resizable panel, now I can resize it so the header and close button is no longer visible, and there is no way to close the panel.
image

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Apr 7, 2025

I think we should limit the height of the resizable panel, now I can resize it so the header and close button is no longer visible, and there is no way to close the panel.

Yes that's a good point addressed in 0248d1d

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Apr 7, 2025

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet nchaulet enabled auto-merge (squash) April 7, 2025 15:13
@nchaulet nchaulet merged commit 32f2cf6 into elastic:main Apr 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 1199 1201 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +4.1KB

History

cc @nchaulet

baileycash-elastic pushed a commit to baileycash-elastic/kibana that referenced this pull request Apr 7, 2025
@juliaElastic
Copy link
Copy Markdown
Contributor

@nchaulet Noticed a bug, when deleting integration policies in the split view, the Installed integration view is not being refreshed.

image

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Apr 9, 2025

@nchaulet Noticed a bug, when deleting integration policies in the split view, the Installed integration view is not being refreshed.

Thanks for testing looks like we will have to invalidate some queries on installation removal, will do a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Wire up view policies in new installed integrations UI

4 participants