[Security Solution] Onboarding check inference endpoint#217150
Merged
semd merged 9 commits intoelastic:mainfrom Apr 7, 2025
Merged
[Security Solution] Onboarding check inference endpoint#217150semd merged 9 commits intoelastic:mainfrom
semd merged 9 commits intoelastic:mainfrom
Conversation
semd
added
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
agusruidiazgd
approved these changes
Apr 4, 2025
Contributor
agusruidiazgd
left a comment
agusruidiazgd
left a comment
There was a problem hiding this comment.
LGTM 👏 thanks for this changes Sergi!
...lution/public/onboarding/components/onboarding_body/cards/common/connectors/ai_connectors.ts
Show resolved
Hide resolved
...urity_solution/public/onboarding/components/onboarding_body/cards/common/connectors/authz.ts
Show resolved
Hide resolved
logeekal
reviewed
Apr 4, 2025
...lution/public/onboarding/components/onboarding_body/cards/common/connectors/ai_connectors.ts
Outdated
Show resolved
Hide resolved
logeekal
reviewed
Apr 4, 2025
Contributor
logeekal
left a comment
logeekal
left a comment
There was a problem hiding this comment.
Code Looks good. Thanks. Left couple of comments but nothing to block the PR.
Doing desk testing right now and then will post another review soon.
...ion/public/onboarding/components/onboarding_body/cards/common/connectors/connector_cards.tsx
Show resolved
Hide resolved
...lution/public/onboarding/components/onboarding_body/cards/common/connectors/ai_connectors.ts
Outdated
Show resolved
Hide resolved
logeekal
approved these changes
Apr 7, 2025
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/14310831547 |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @semd |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
semd
added a commit
to semd/kibana
that referenced
this pull request
Apr 7, 2025
## Summary This PR checks that the inference endpoint exists before showing the inference connector in the list of selectable connectors. Also, it removes code duplication by centralizing the implementation in the /common/connectors directory of the onboarding cards   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7b934f9) # Conflicts: # x-pack/solutions/security/plugins/security_solution/tsconfig.json
semd
added a commit
to semd/kibana
that referenced
this pull request
Apr 7, 2025
## Summary This PR checks that the inference endpoint exists before showing the inference connector in the list of selectable connectors. Also, it removes code duplication by centralizing the implementation in the /common/connectors directory of the onboarding cards   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7b934f9) # Conflicts: # x-pack/solutions/security/plugins/security_solution/tsconfig.json
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
semd
added a commit
to semd/kibana
that referenced
this pull request
Apr 7, 2025
## Summary This PR checks that the inference endpoint exists before showing the inference connector in the list of selectable connectors. Also, it removes code duplication by centralizing the implementation in the /common/connectors directory of the onboarding cards   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7b934f9) # Conflicts: # x-pack/solutions/security/plugins/security_solution/tsconfig.json
semd
added a commit
that referenced
this pull request
Apr 7, 2025
… (#217330) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Onboarding check inference endpoint (#217150)](#217150) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T13:43:39Z","message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Onboarding check inference endpoint","number":217150,"url":"https://github.com/elastic/kibana/pull/217150","mergeCommit":{"message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217150","number":217150,"mergeCommit":{"message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
semd
added a commit
that referenced
this pull request
Apr 7, 2025
…) (#217335) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Onboarding check inference endpoint (#217150)](#217150) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T13:43:39Z","message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Onboarding check inference endpoint","number":217150,"url":"https://github.com/elastic/kibana/pull/217150","mergeCommit":{"message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217150","number":217150,"mergeCommit":{"message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
semd
added a commit
that referenced
this pull request
Apr 7, 2025
… (#217333) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Onboarding check inference endpoint (#217150)](#217150) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2025-04-07T13:43:39Z","message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Onboarding check inference endpoint","number":217150,"url":"https://github.com/elastic/kibana/pull/217150","mergeCommit":{"message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217150","number":217150,"mergeCommit":{"message":"[Security Solution] Onboarding check inference endpoint (#217150)\n\n## Summary\n\nThis PR checks that the inference endpoint exists before showing the\ninference connector in the list of selectable connectors.\n\nAlso, it removes code duplication by centralizing the implementation in\nthe /common/connectors directory of the onboarding cards\n\n\n\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7b934f903499d1affd1986fedb0529f51d5c818c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
baileycash-elastic
pushed a commit
to baileycash-elastic/kibana
that referenced
this pull request
Apr 7, 2025
## Summary This PR checks that the inference endpoint exists before showing the inference connector in the list of selectable connectors. Also, it removes code duplication by centralizing the implementation in the /common/connectors directory of the onboarding cards   --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adresses: https://github.com/elastic/security-team/issues/12332
This PR checks that the inference endpoint exists before showing the inference connector in the list of selectable connectors.
Also, it removes code duplication by centralizing the implementation in the /common/connectors directory of the onboarding cards
Screenshots
Before:
After: