[Incident Management] Investigation guide frontend#217106
Merged
justinkambic merged 403 commits intoelastic:mainfrom May 29, 2025
Merged
[Incident Management] Investigation guide frontend#217106justinkambic merged 403 commits intoelastic:mainfrom
justinkambic merged 403 commits intoelastic:mainfrom
Conversation
justinkambic
added
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
justinkambic
added
release_note:feature
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jloleysens
approved these changes
Apr 14, 2025
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Addition of optional artifacts field to SO (unmapped) LGTM!
… into artifacts_dashboard_schema
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
|
Contributor
|
Flaky test runner link here |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary This implements some design changes for the Rule create/edit form that are needed downstream in elastic#217106 and elastic#219019. Once we are agreed on the implementation and ok to merge, we can go ahead. In the meantime, we can pull these changes into the existing PRs mentioned above so we can work on finalizing the layout as it will look, without needing to duplicate these commits in both places. ### Updated create rule form <img width="1236" alt="image" src="https://github.com/user-attachments/assets/06925dfe-bd61-4f99-bdca-2cdf7bbb5f60" /> ### Updated details tab in edit flyout <img width="776" alt="image" src="https://github.com/user-attachments/assets/b250a4c9-fb2d-41cd-910a-aa42b61b5a5c" />
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8308[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 174/200 tests passed. |
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15327853248 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 29, 2025
## Summary 🌹 Resolves elastic#213024. The frontend changes for [elastic#216377](elastic#216377). Depends on elastic#216377 and elastic#216292. ## Testing these changes 🌸 This adds frontend integration with the API changes we previously merged in elastic#216377. There is a new editor in the Rule Create/Edit Detail view, below the pre-existing field for naming the rule. To test that this feature is working you should: - This is easiest to test if you have actual data that will trigger an alert in your cluster. If you need some fake data, you can use the nifty `data-forge` utility with a command like: ```shell node x-pack/scripts/data_forge.js --events-per-cycle 200 --lookback now-1h --ephemeral-project-ids 10 --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601 --event-template bad ``` - Create a rule with an investigation guide specified. This is easy. Write some Markdown text into the editor and save the rule. My favorite rule for testing the feature is Custom Threshold, because it's easy to configure an alert that will fire. But this works for any rule. <img width="1260" alt="image" src="https://github.com/user-attachments/assets/bf9bf866-2439-456a-a700-1a93ae2e5dac" /> - After you create your rule, it should fire at some point, ideally. Using the Observability -> Alerts view, drill into the Alert Details page. There, you should find a spiffy new tab called _Investigation Guide_. Confirm the contents on that tab are your markdown, properly rendered. <img width="1000" alt="image" src="https://github.com/user-attachments/assets/bff19e48-da44-4886-bcf7-a296559c0aca" /> - Repeat step 1-2 as many times as you like with different rule types, if you desire. - Edit your rule, using the edit page or flyout. <img width="606" alt="image" src="https://github.com/user-attachments/assets/1a6149fe-016a-4b8c-9846-24cb2931aed3" /> - When you save the rule you should be able to refresh the alert details page and see the modified Investigation Guide reflected in the tab. --------- Co-authored-by: Panagiota Mitsopoulou <giota85@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6b556d5)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 29, 2025
…221956) # Backport This will backport the following commits from `main` to `8.19`: - [[Incident Management] Investigation guide frontend (#217106)](#217106) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Justin Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T15:49:20Z","message":"[Incident Management] Investigation guide frontend (#217106)\n\n## Summary 🌹\n\nResolves #213024.\n\nThe frontend changes for\n[#216377](https://github.com/elastic/kibana/pull/216377).\n\nDepends on #216377 and https://github.com/elastic/kibana/pull/216292.\n\n## Testing these changes 🌸\n\nThis adds frontend integration with the API changes we previously merged\nin #216377. There is a new editor in the Rule Create/Edit Detail view,\nbelow the pre-existing field for naming the rule.\n\nTo test that this feature is working you should:\n\n- This is easiest to test if you have actual data that will trigger an\nalert in your cluster. If you need some fake data, you can use the nifty\n`data-forge` utility with a command like:\n```shell\nnode x-pack/scripts/data_forge.js --events-per-cycle 200 --lookback now-1h --ephemeral-project-ids 10 --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601 --event-template bad\n```\n- Create a rule with an investigation guide specified. This is easy.\nWrite some Markdown text into the editor and save the rule. My favorite\nrule for testing the feature is Custom Threshold, because it's easy to\nconfigure an alert that will fire. But this works for any rule.\n<img width=\"1260\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bf9bf866-2439-456a-a700-1a93ae2e5dac\"\n/>\n\n- After you create your rule, it should fire at some point, ideally.\nUsing the Observability -> Alerts view, drill into the Alert Details\npage. There, you should find a spiffy new tab called _Investigation\nGuide_. Confirm the contents on that tab are your markdown, properly\nrendered.\n\n<img width=\"1000\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bff19e48-da44-4886-bcf7-a296559c0aca\"\n/>\n\n- Repeat step 1-2 as many times as you like with different rule types,\nif you desire.\n- Edit your rule, using the edit page or flyout.\n\n<img width=\"606\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/1a6149fe-016a-4b8c-9846-24cb2931aed3\"\n/>\n\n- When you save the rule you should be able to refresh the alert details\npage and see the modified Investigation Guide reflected in the tab.\n\n---------\n\nCo-authored-by: Panagiota Mitsopoulou <giota85@gmail.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6b556d593fb8a906290f00cfb55268a6a8fbed46","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Incident Management] Investigation guide frontend","number":217106,"url":"https://github.com/elastic/kibana/pull/217106","mergeCommit":{"message":"[Incident Management] Investigation guide frontend (#217106)\n\n## Summary 🌹\n\nResolves #213024.\n\nThe frontend changes for\n[#216377](https://github.com/elastic/kibana/pull/216377).\n\nDepends on #216377 and https://github.com/elastic/kibana/pull/216292.\n\n## Testing these changes 🌸\n\nThis adds frontend integration with the API changes we previously merged\nin #216377. There is a new editor in the Rule Create/Edit Detail view,\nbelow the pre-existing field for naming the rule.\n\nTo test that this feature is working you should:\n\n- This is easiest to test if you have actual data that will trigger an\nalert in your cluster. If you need some fake data, you can use the nifty\n`data-forge` utility with a command like:\n```shell\nnode x-pack/scripts/data_forge.js --events-per-cycle 200 --lookback now-1h --ephemeral-project-ids 10 --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601 --event-template bad\n```\n- Create a rule with an investigation guide specified. This is easy.\nWrite some Markdown text into the editor and save the rule. My favorite\nrule for testing the feature is Custom Threshold, because it's easy to\nconfigure an alert that will fire. But this works for any rule.\n<img width=\"1260\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bf9bf866-2439-456a-a700-1a93ae2e5dac\"\n/>\n\n- After you create your rule, it should fire at some point, ideally.\nUsing the Observability -> Alerts view, drill into the Alert Details\npage. There, you should find a spiffy new tab called _Investigation\nGuide_. Confirm the contents on that tab are your markdown, properly\nrendered.\n\n<img width=\"1000\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bff19e48-da44-4886-bcf7-a296559c0aca\"\n/>\n\n- Repeat step 1-2 as many times as you like with different rule types,\nif you desire.\n- Edit your rule, using the edit page or flyout.\n\n<img width=\"606\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/1a6149fe-016a-4b8c-9846-24cb2931aed3\"\n/>\n\n- When you save the rule you should be able to refresh the alert details\npage and see the modified Investigation Guide reflected in the tab.\n\n---------\n\nCo-authored-by: Panagiota Mitsopoulou <giota85@gmail.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6b556d593fb8a906290f00cfb55268a6a8fbed46"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217106","number":217106,"mergeCommit":{"message":"[Incident Management] Investigation guide frontend (#217106)\n\n## Summary 🌹\n\nResolves #213024.\n\nThe frontend changes for\n[#216377](https://github.com/elastic/kibana/pull/216377).\n\nDepends on #216377 and https://github.com/elastic/kibana/pull/216292.\n\n## Testing these changes 🌸\n\nThis adds frontend integration with the API changes we previously merged\nin #216377. There is a new editor in the Rule Create/Edit Detail view,\nbelow the pre-existing field for naming the rule.\n\nTo test that this feature is working you should:\n\n- This is easiest to test if you have actual data that will trigger an\nalert in your cluster. If you need some fake data, you can use the nifty\n`data-forge` utility with a command like:\n```shell\nnode x-pack/scripts/data_forge.js --events-per-cycle 200 --lookback now-1h --ephemeral-project-ids 10 --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601 --event-template bad\n```\n- Create a rule with an investigation guide specified. This is easy.\nWrite some Markdown text into the editor and save the rule. My favorite\nrule for testing the feature is Custom Threshold, because it's easy to\nconfigure an alert that will fire. But this works for any rule.\n<img width=\"1260\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bf9bf866-2439-456a-a700-1a93ae2e5dac\"\n/>\n\n- After you create your rule, it should fire at some point, ideally.\nUsing the Observability -> Alerts view, drill into the Alert Details\npage. There, you should find a spiffy new tab called _Investigation\nGuide_. Confirm the contents on that tab are your markdown, properly\nrendered.\n\n<img width=\"1000\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/bff19e48-da44-4886-bcf7-a296559c0aca\"\n/>\n\n- Repeat step 1-2 as many times as you like with different rule types,\nif you desire.\n- Edit your rule, using the edit page or flyout.\n\n<img width=\"606\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/1a6149fe-016a-4b8c-9846-24cb2931aed3\"\n/>\n\n- When you save the rule you should be able to refresh the alert details\npage and see the modified Investigation Guide reflected in the tab.\n\n---------\n\nCo-authored-by: Panagiota Mitsopoulou <giota85@gmail.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6b556d593fb8a906290f00cfb55268a6a8fbed46"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Justin Kambic <jk@elastic.co> Co-authored-by: Panagiota Mitsopoulou <giota85@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
## Summary This implements some design changes for the Rule create/edit form that are needed downstream in elastic#217106 and elastic#219019. Once we are agreed on the implementation and ok to merge, we can go ahead. In the meantime, we can pull these changes into the existing PRs mentioned above so we can work on finalizing the layout as it will look, without needing to duplicate these commits in both places. ### Updated create rule form <img width="1236" alt="image" src="https://github.com/user-attachments/assets/06925dfe-bd61-4f99-bdca-2cdf7bbb5f60" /> ### Updated details tab in edit flyout <img width="776" alt="image" src="https://github.com/user-attachments/assets/b250a4c9-fb2d-41cd-910a-aa42b61b5a5c" />
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary 🌹 Resolves elastic#213024. The frontend changes for [elastic#216377](elastic#216377). Depends on elastic#216377 and elastic#216292. ## Testing these changes 🌸 This adds frontend integration with the API changes we previously merged in elastic#216377. There is a new editor in the Rule Create/Edit Detail view, below the pre-existing field for naming the rule. To test that this feature is working you should: - This is easiest to test if you have actual data that will trigger an alert in your cluster. If you need some fake data, you can use the nifty `data-forge` utility with a command like: ```shell node x-pack/scripts/data_forge.js --events-per-cycle 200 --lookback now-1h --ephemeral-project-ids 10 --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601 --event-template bad ``` - Create a rule with an investigation guide specified. This is easy. Write some Markdown text into the editor and save the rule. My favorite rule for testing the feature is Custom Threshold, because it's easy to configure an alert that will fire. But this works for any rule. <img width="1260" alt="image" src="https://github.com/user-attachments/assets/bf9bf866-2439-456a-a700-1a93ae2e5dac" /> - After you create your rule, it should fire at some point, ideally. Using the Observability -> Alerts view, drill into the Alert Details page. There, you should find a spiffy new tab called _Investigation Guide_. Confirm the contents on that tab are your markdown, properly rendered. <img width="1000" alt="image" src="https://github.com/user-attachments/assets/bff19e48-da44-4886-bcf7-a296559c0aca" /> - Repeat step 1-2 as many times as you like with different rule types, if you desire. - Edit your rule, using the edit page or flyout. <img width="606" alt="image" src="https://github.com/user-attachments/assets/1a6149fe-016a-4b8c-9846-24cb2931aed3" /> - When you save the rule you should be able to refresh the alert details page and see the modified Investigation Guide reflected in the tab. --------- Co-authored-by: Panagiota Mitsopoulou <giota85@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
## Summary 🌹 Resolves elastic#213024. The frontend changes for [elastic#216377](elastic#216377). Depends on elastic#216377 and elastic#216292. ## Testing these changes 🌸 This adds frontend integration with the API changes we previously merged in elastic#216377. There is a new editor in the Rule Create/Edit Detail view, below the pre-existing field for naming the rule. To test that this feature is working you should: - This is easiest to test if you have actual data that will trigger an alert in your cluster. If you need some fake data, you can use the nifty `data-forge` utility with a command like: ```shell node x-pack/scripts/data_forge.js --events-per-cycle 200 --lookback now-1h --ephemeral-project-ids 10 --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601 --event-template bad ``` - Create a rule with an investigation guide specified. This is easy. Write some Markdown text into the editor and save the rule. My favorite rule for testing the feature is Custom Threshold, because it's easy to configure an alert that will fire. But this works for any rule. <img width="1260" alt="image" src="https://github.com/user-attachments/assets/bf9bf866-2439-456a-a700-1a93ae2e5dac" /> - After you create your rule, it should fire at some point, ideally. Using the Observability -> Alerts view, drill into the Alert Details page. There, you should find a spiffy new tab called _Investigation Guide_. Confirm the contents on that tab are your markdown, properly rendered. <img width="1000" alt="image" src="https://github.com/user-attachments/assets/bff19e48-da44-4886-bcf7-a296559c0aca" /> - Repeat step 1-2 as many times as you like with different rule types, if you desire. - Edit your rule, using the edit page or flyout. <img width="606" alt="image" src="https://github.com/user-attachments/assets/1a6149fe-016a-4b8c-9846-24cb2931aed3" /> - When you save the rule you should be able to refresh the alert details page and see the modified Investigation Guide reflected in the tab. --------- Co-authored-by: Panagiota Mitsopoulou <giota85@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 🌹
Resolves #213024.
The frontend changes for #216377.
Depends on #216377 and #216292.
Testing these changes 🌸
This adds frontend integration with the API changes we previously merged in #216377. There is a new editor in the Rule Create/Edit Detail view, below the pre-existing field for naming the rule.
To test that this feature is working you should:
data-forgeutility with a command like: