[Dashboards] Update response on HTTP API should return a 200, not 201 #217054
Merged
olapawlus merged 4 commits intoelastic:mainfrom Apr 4, 2025
Merged
[Dashboards] Update response on HTTP API should return a 200, not 201 #217054olapawlus merged 4 commits intoelastic:mainfrom
olapawlus merged 4 commits intoelastic:mainfrom
Conversation
olapawlus
added
bug
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Apr 4, 2025
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! Great work updating the code and the tests!
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/14271188486 |
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @olapawlus |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
olapawlus
added
v8.18.1
v8.17.5
v9.0.1
backport:version
Contributor
|
Starting backport for target branches: 8.17, 8.18, 9.0 https://github.com/elastic/kibana/actions/runs/14311042179 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Apr 8, 2025
Merged
Member
Author
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
olapawlus
added a commit
to olapawlus/kibana
that referenced
this pull request
Apr 8, 2025
…elastic#217054) ## Summary Changes response from 201 to 200 in the dashboard updateRoute. Closes: elastic#212673 (cherry picked from commit 3c2b4da) # Conflicts: # src/platform/test/api_integration/apis/dashboards/update_dashboard/main.ts
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
olapawlus
added a commit
to olapawlus/kibana
that referenced
this pull request
Apr 8, 2025
…elastic#217054) ## Summary Changes response from 201 to 200 in the dashboard updateRoute. Closes: elastic#212673 (cherry picked from commit 3c2b4da) # Conflicts: # src/platform/test/api_integration/apis/dashboards/update_dashboard/main.ts
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
olapawlus
added a commit
that referenced
this pull request
Apr 10, 2025
…not 201 (#217054) (#217494) # Backport This will backport the following commits from `main` to `8.18`: - [[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)](#217054) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ola","email":"98127445+olapawlus@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-04T17:48:58Z","message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","backport:version","v9.1.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Dashboards] Update response on HTTP API should return a 200, not 201 ","number":217054,"url":"https://github.com/elastic/kibana/pull/217054","mergeCommit":{"message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217054","number":217054,"mergeCommit":{"message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
olapawlus
added a commit
that referenced
this pull request
Apr 10, 2025
…ot 201 (#217054) (#217499) # Backport This will backport the following commits from `main` to `9.0`: - [[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)](#217054) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ola","email":"98127445+olapawlus@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-04T17:48:58Z","message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","backport:version","v9.1.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Dashboards] Update response on HTTP API should return a 200, not 201 ","number":217054,"url":"https://github.com/elastic/kibana/pull/217054","mergeCommit":{"message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217054","number":217054,"mergeCommit":{"message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217494","number":217494,"state":"OPEN"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217498","number":217498,"state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
olapawlus
added a commit
that referenced
this pull request
Apr 11, 2025
…not 201 (#217054) (#217498) # Backport This will backport the following commits from `main` to `8.17`: - [[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)](#217054) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ola","email":"98127445+olapawlus@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-04T17:48:58Z","message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","backport:version","v9.1.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Dashboards] Update response on HTTP API should return a 200, not 201 ","number":217054,"url":"https://github.com/elastic/kibana/pull/217054","mergeCommit":{"message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217054","number":217054,"mergeCommit":{"message":"[Dashboards] Update response on HTTP API should return a 200, not 201 (#217054)\n\n## Summary\n\nChanges response from 201 to 200 in the dashboard updateRoute.\n\nCloses: #212673","sha":"3c2b4daf97fdaea09cd1cd33b71c561344ec90b0"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Contributor
|
This PR didn't make it into the latest BC. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes response from 201 to 200 in the dashboard updateRoute.
Closes: #212673